Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buildx CLI shouldn't require secrets #609

Open
LeulBM opened this issue Jul 11, 2024 · 1 comment · May be fixed by #651
Open

Buildx CLI shouldn't require secrets #609

LeulBM opened this issue Jul 11, 2024 · 1 comment · May be fixed by #651

Comments

@LeulBM
Copy link

LeulBM commented Jul 11, 2024

The BuildxCLI build command requires the secrets argument to be set, but docker buildx build does not actually require a --secret flag to be set to successfully run. Making secrets optional would bring this behavior in line with the docker buildx build command
@gabrieldemarmiesse
Copy link
Owner

I'm open to a pull request in this direction :)

@Felixoid Felixoid linked a pull request Nov 19, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add tests for secrets in BuildxCLI to show that they are optional Felixoid/python-on-whales
2 participants
@gabrieldemarmiesse @LeulBM