-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DockerClient.info()
doesn't work with podman
#592
Comments
It makes sense that the info is different as podman and docker work differently internally, so I'm not blaming them for this. What I see is that we may need a better support for docker/podman differences. Looking at the popularity of Docker vs Podman: https://github.com/moby/moby vs https://github.com/containers/podman, I think it's fair to say that we should also support the kwirks of podman correctly. Seeing long-term, I think we'll need better support for the podman/docker differences, but at the moment, would it be possible to fit the information of podman info into the DockerInfo pydantic model? Some fields won't be equivalent, but we can do a best effort here. What do you think? |
I'm happy to hear this :)
I'm not particularly keen on this idea, I'm not sure stuff would map very well and it would create transition friction if we then switch to handling it in a more complete way. Do you have any initial thoughts on how we might support docker/podman differences in cases like this? One option would be to just return different objects based on which is being used, e.g. |
Concerning the option with DockerCLient and PodmanClient, indeed the whole difficulty will be with the class hierarchy. One solution we can explore too, would be to make |
This is arguably podman's fault for not maintaining compatibility with this command :(
Here's what you get from podman:
Is there anything we can do about this in PoW, or is the statement that we'll only support CLIs compatible with docker?
The text was updated successfully, but these errors were encountered: