From eeb16a5f8138671d42a9df75e972db67fcebe860 Mon Sep 17 00:00:00 2001 From: gaasedelen Date: Mon, 5 Feb 2024 13:03:41 -0500 Subject: [PATCH] final fixes, ticking version numbers --- README.md | 1 + plugins/lighthouse/integration/binja_integration.py | 8 +++++++- plugins/lighthouse/integration/core.py | 2 +- 3 files changed, 9 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 9369799..b7fad83 100644 --- a/README.md +++ b/README.md @@ -194,6 +194,7 @@ Lighthouse will remember your theme preference for future loads and uses. Time and motivation permitting, future work may include: +* Nag Vector35 to fix HLIL highlighting ([bug](https://github.com/Vector35/binaryninja-api/issues/2584)) in Binary Ninja * ~~Asynchronous composition, painting, metadata collection~~ * ~~Multifile/coverage support~~ * Profiling based heatmaps/painting diff --git a/plugins/lighthouse/integration/binja_integration.py b/plugins/lighthouse/integration/binja_integration.py index e7f5a98..cb5df93 100644 --- a/plugins/lighthouse/integration/binja_integration.py +++ b/plugins/lighthouse/integration/binja_integration.py @@ -209,6 +209,12 @@ def _open_coverage_overview(self, context): return super(LighthouseBinja, self).open_coverage_overview(dctx) + def _stub(self, context): + # XXX: This was added as a last minute bodge prior to releasing v0.9.3, + # it fixes a crash-on-close that was manifesting on binja macOS, when + # using a lambda instead of a concrete function/stub like this. + return None + #-------------------------------------------------------------------------- # Binja Actions #-------------------------------------------------------------------------- @@ -235,7 +241,7 @@ def _install_load_batch(self): def _install_open_coverage_xref(self): action = self.ACTION_COVERAGE_XREF UIAction.registerAction(action) - UIActionHandler.globalActions().bindAction(action, UIAction(lambda context: None, self._interactive_coverage_xref)) + UIActionHandler.globalActions().bindAction(action, UIAction(self._stub, self._interactive_coverage_xref)) Menu.mainMenu("Plugins").addAction(action, "Loading", 2) # NOTE/V35: Binja automatically creates View --> Show Coverage Overview diff --git a/plugins/lighthouse/integration/core.py b/plugins/lighthouse/integration/core.py index 38bf0d4..e1c05f1 100644 --- a/plugins/lighthouse/integration/core.py +++ b/plugins/lighthouse/integration/core.py @@ -25,7 +25,7 @@ class LighthouseCore(object): # Plugin Metadata #-------------------------------------------------------------------------- - PLUGIN_VERSION = "0.9.3-RC" + PLUGIN_VERSION = "0.9.3" AUTHORS = "Markus Gaasedelen" DATE = "2024"