Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scope all imports #198

Open
stewartboogert opened this issue Oct 26, 2024 · 2 comments
Open

scope all imports #198

stewartboogert opened this issue Oct 26, 2024 · 2 comments

Comments

@stewartboogert
Copy link
Member

Need to properly scope all imports

e.g.

import numpy as _np

Makes it much easier to change the import structure in the future

@gipert
Copy link
Member

gipert commented Oct 26, 2024

I would propose to remove the underscore in front, it's not really needed and makes code prettier :)

@stewartboogert
Copy link
Member Author

stewartboogert commented Oct 26, 2024

Agreed but it forms part of what is imported with a module. So if users mechanism is not reading (the code or manual) and just "tabbing" around different classes it clutters the available scope

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants