Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New tab button broken #29

Open
markknol opened this issue Nov 3, 2023 · 0 comments
Open

New tab button broken #29

markknol opened this issue Nov 3, 2023 · 0 comments

Comments

@markknol
Copy link

markknol commented Nov 3, 2023

There is a small bug in the "new tab" button. The current fxhash.js api expects a hash starting with "#0x" to infer the params. If you press "new tab", it uses &fxparams=0x... (a querystring, not hash) in the url, which result in displaying a random artwork, not the expected parameterized artwork.

            const p = [
              `fxhash=${runtime.state.hash}`,
              `fxparams=0x${bytes}`,
              `fxminter=${runtime.state.minter}`,
            ]

should be

            const p = [
              `fxhash=${runtime.state.hash}`,
              `fxminter=${runtime.state.minter}`,
              `#0x${bytes}`,
            ]

Source:

`fxparams=0x${bytes}`,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant