Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Article editor] SHIFT + ENTER should insert a new line, and not insert a new block #304

Open
ciphrd opened this issue Jul 30, 2022 · 1 comment · May be fixed by #306
Open

[Article editor] SHIFT + ENTER should insert a new line, and not insert a new block #304

ciphrd opened this issue Jul 30, 2022 · 1 comment · May be fixed by #306
Assignees
@maerzhase
Labels
enhancement New feature or request
Milestone
Articles standalone

Comments

@ciphrd
Copy link
Collaborator

ciphrd commented Jul 30, 2022

  • base branch: feature/articles

When the cursor is in the following blocks:

  • p
  • ul/ol
  • blockquote

Pressing SHIFT + ENTER should insert a new line within the block
@ciphrd ciphrd added the enhancement New feature or request label Jul 30, 2022
@ciphrd ciphrd added this to the Articles standalone milestone Jul 30, 2022
@maerzhase
Copy link
Contributor

maerzhase commented Aug 1, 2022 •
edited
Loading

Surprisingly the editor exposes an API for softbreak

  insertSoftBreak: () => void

https://docs.slatejs.org/concepts/07-editor

@maerzhase maerzhase self-assigned this Aug 1, 2022
maerzhase added a commit that referenced this issue Aug 1, 2022
@maerzhase
add softbreak plugin; fix #304
90ba32e
@maerzhase maerzhase linked a pull request Aug 1, 2022 that will close this issue
Open
maerzhase added a commit that referenced this issue Aug 5, 2022
@maerzhase
Merge branch 'feature/articles' into fix/#304-softbreak-plugin
94b6ca8
@maerzhase maerzhase linked a pull request Aug 11, 2022 that will close this issue
Feature/artciles: add softbreak plugin #306
Open
maerzhase added a commit that referenced this issue Sep 19, 2022
@maerzhase
Merge branch 'dev' into fix/#304-softbreak-plugin
8e0c1a2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maerzhase maerzhase

Labels
enhancement New feature or request
Projects
None yet
Milestone
Articles standalone
Development

Successfully merging a pull request may close this issue.

Feature/artciles: add softbreak plugin fxhash/fxhash-website
2 participants
@maerzhase @ciphrd