Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Article editor, markdown transformation of the text if syntax is valid #219

Open
ciphrd opened this issue Jun 21, 2022 · 7 comments · May be fixed by #301
Open

Article editor, markdown transformation of the text if syntax is valid #219

ciphrd opened this issue Jun 21, 2022 · 7 comments · May be fixed by #301
Assignees
@maerzhase
Labels
enhancement New feature or request
Milestone
Articles standalone

Comments

@ciphrd
Copy link
Collaborator

ciphrd commented Jun 21, 2022 •
edited
Loading

  • PR target branch: feature/articles

Any text which introduces some valid markdown nodes should be turned into their corresponding block on-the-fly.

The following plugin can most likely be used for that purpose:

https://yarnpkg.com/en/package/slate-auto-replace
@ciphrd ciphrd added the enhancement New feature or request label Jun 21, 2022
@maerzhase maerzhase self-assigned this Jun 23, 2022
@maerzhase
Copy link
Contributor

maerzhase commented Jun 23, 2022 •
edited
Loading

Unfortunately the plugin is outdated too. but I created another plugin already, that supports this feature

@ciphrd ciphrd added this to the Articles standalone milestone Jul 27, 2022
@maerzhase
Copy link
Contributor

maerzhase commented Jul 28, 2022 •
edited
Loading

The AutoFormatPlugin implements this:

fxhash-website/src/components/NFTArticle/SlateEditor/AutoFormatPlugin/index.tsx

Lines 28 to 34 in 182564a

const config: AutoFormatChange[] = [
...createChangeTypeHeading(),
new BlockTypeChange('p', {type: 'paragraph',} ),
new InlineTypeChange('__', {strong: true}),
new InlineTypeChange('_', {emphasis: true}),
new CustomDirectiveChange('tezos-storage'),
]

Will take care of the others next:

  • List -
  • Link []()
  • Blockquote >

@maerzhase maerzhase linked a pull request Jul 30, 2022 that will close this issue
Open
15 tasks
maerzhase added a commit that referenced this issue Jul 30, 2022
@maerzhase
Merge branch 'feature/articles' into feature/#219-transform-valid-mar…
37d124a 
…kdown-to-nodes
maerzhase added a commit that referenced this issue Jul 30, 2022
@maerzhase
Merge branch 'feature/articles' into feature/#219-transform-valid-mar…
88470bc 
…kdown-to-nodes
@maerzhase maerzhase linked a pull request Jul 30, 2022 that will close this issue
Feature/articles: transform valid markdown to nodes #301
Open
15 tasks
maerzhase added a commit that referenced this issue Aug 9, 2022
@maerzhase
Merge branch 'feature/articles' into feature/#219-transform-valid-mar…
e5f8083 
…kdown-to-nodes
maerzhase added a commit that referenced this issue Aug 11, 2022
@maerzhase
Merge branch 'feature/articles' into feature/#219-transform-valid-mar…
9b55cc4 
…kdown-to-nodes
maerzhase added a commit that referenced this issue Aug 28, 2022
@maerzhase
Merge branch 'dev' into feature/#219-transform-valid-markdown-to-nodes
4fb2f6f
@liamegan
Copy link
Contributor

liamegan commented Sep 6, 2022

@ciphrd safe to close?

@GemN
Copy link
Contributor

GemN commented Sep 6, 2022

@liamegan it's W.I.P by @maerzhase - only math remaining I believe, it will automatically close when merged

@liamegan
Copy link
Contributor

liamegan commented Sep 6, 2022 •
edited
Loading

@GemN for sure, I'm just going through and cleaning up old, redundant PRs and issues.

maerzhase added a commit that referenced this issue Sep 24, 2022
@maerzhase
Merge branch 'feature/articles' into feature/#219-transform-valid-mar…
d02d2be 
…kdown-to-nodes
@GemN
Copy link
Contributor

GemN commented Jan 24, 2023

@maerzhase current status?

@maerzhase
Copy link
Contributor

maerzhase commented Apr 17, 2023 •
edited
Loading

its basically implemented here:

does need proper user testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maerzhase maerzhase

Labels
enhancement New feature or request
Projects
None yet
Milestone
Articles standalone
Development

Successfully merging a pull request may close this issue.

Feature/articles: transform valid markdown to nodes fxhash/fxhash-website
4 participants
@liamegan @maerzhase @GemN @ciphrd