Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[*] Feature: Automated nightly releases #40

Open
wants to merge 2 commits into
base: cloned_main_bd0c2
Choose a base branch
from

Conversation

local-dev-korbit-ai-mentor[bot]
Copy link

@local-dev-korbit-ai-mentor local-dev-korbit-ai-mentor bot commented Aug 15, 2024

Description

Refactor release workflow to use reusable workflows so the work can be shared

Add a nightly workflow to create a release every night in the nightly channel

Maintain release channel branches (latest__release, nightly__release) so that we will have the option to build the docs site from the latest released version instead of or in addition to main (#6144)

Closes #6169

Test plan

  • Try creating a release to make sure that still works
  • See if it works when the cron job runs?
  • I created very similar workflows and scripts in this repo to see if it should work and it did https://github.com/etrepum/lexical-builder

Future Considerations

  • Fix release process to use the same tag for both GitHub and NPM releases (the nightly release does not have this issue, only manual workflow_dispatch releases with a PR)
  • Do not do a nightly release when there are no changes since the last one

Description by Korbit AI

What change is being made?

Add scripts/npm/** to the .prettierignore file to exclude it from Prettier formatting.

Why are these changes being made?

The scripts/npm/** directory contains scripts necessary for automated nightly releases, which should not be formatted by Prettier to avoid potential issues with script execution. This ensures that the release process remains stable and unaffected by code formatting changes.

Summary by CodeRabbit

  • Chores
    • Updated Prettier configuration to include the scripts/npm directory for formatting, allowing for better consistency in code style.

Copy link
Author

Clone of the PR facebook/lexical#6204

Copy link

korbit-ai bot commented Aug 15, 2024

My review is in progress 📖 - I will have feedback for you in a few minutes!

Copy link

coderabbitai bot commented Aug 15, 2024

Walkthrough

The recent updates to the project include a modification to the .prettierignore file, specifically allowing files within the scripts/npm directory to be formatted by Prettier. This change enhances the formatting capabilities of Prettier by including additional files while maintaining exclusions for other specified directories.

Changes

File Change Summary
.prettierignore Added exception for scripts/npm/**, allowing formatting of files within this directory.

Poem

🐰 In the garden of code where the rabbits play,
Prettier hops in, brightening the day.
Scripts once ignored now dance in the light,
Formatting joy, oh, what a delight!
With a flick of my ear and a skip in my hop,
Clean code is our goal— we’ll never stop! 🌼✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@korbit-ai korbit-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed your code and did not find any issues!


Please note that I can make mistakes, and you should still encourage your team to review your code as well.

@furwellness
Copy link
Owner

/review

Copy link

codiumai-pr-agent-free bot commented Aug 16, 2024

PR Reviewer Guide 🔍

(Review updated until commit 7a5a843)

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ No key issues to review

Copy link

Persistent review updated to latest commit 7a5a843

@furwellness
Copy link
Owner

@coderabbitai review

Copy link

coderabbitai bot commented Aug 16, 2024

Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between bd0c209 and 7a5a843.

Files selected for processing (1)
  • .prettierignore (1 hunks)
Additional comments not posted (1)
.prettierignore (1)

8-8: Allow Prettier to format scripts/npm/**.

The addition of !scripts/npm/** allows Prettier to format files within the scripts/npm directory. This change broadens the scope of files considered for formatting, which can help maintain consistent code style in this directory.

@furwellness
Copy link
Owner

Zero comments from coderabbit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants