-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[*] Feature: Automated nightly releases #40
base: cloned_main_bd0c2
Are you sure you want to change the base?
[*] Feature: Automated nightly releases #40
Conversation
Clone of the PR facebook/lexical#6204 |
My review is in progress 📖 - I will have feedback for you in a few minutes! |
WalkthroughThe recent updates to the project include a modification to the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reviewed your code and did not find any issues!
Please note that I can make mistakes, and you should still encourage your team to review your code as well.
/review |
PR Reviewer Guide 🔍(Review updated until commit 7a5a843)
|
Persistent review updated to latest commit 7a5a843 |
@coderabbitai review |
Actions performedReview triggered.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- .prettierignore (1 hunks)
Additional comments not posted (1)
.prettierignore (1)
8-8
: Allow Prettier to formatscripts/npm/**
.The addition of
!scripts/npm/**
allows Prettier to format files within thescripts/npm
directory. This change broadens the scope of files considered for formatting, which can help maintain consistent code style in this directory.
Zero comments from coderabbit |
Description
Refactor release workflow to use reusable workflows so the work can be shared
Add a nightly workflow to create a release every night in the nightly channel
Maintain release channel branches (
latest__release
,nightly__release
) so that we will have the option to build the docs site from the latest released version instead of or in addition to main (#6144)Closes #6169
Test plan
Future Considerations
Description by Korbit AI
What change is being made?
Add
scripts/npm/**
to the.prettierignore
file to exclude it from Prettier formatting.Why are these changes being made?
The
scripts/npm/**
directory contains scripts necessary for automated nightly releases, which should not be formatted by Prettier to avoid potential issues with script execution. This ensures that the release process remains stable and unaffected by code formatting changes.Summary by CodeRabbit
scripts/npm
directory for formatting, allowing for better consistency in code style.