Bug Fix: Fix selection when hitting "shift+arrowdown" into a table.

[korbit-ai]

Pressing "Shift+ArrowDown" into a table selects only up to the first table-cell node and its children, even though the whole table appears selected.

Description

Previously, the new focus would be set on the table's parent if the current selection was partially within a table. Now, it will be on the first/last cell of the table.

Closes #6273

Before

screencast-playground.lexical.dev-2024.06.07-14_50_45.webm

After

screencast-localhost_3000-2024.06.07-15_27_25.webm

Description by Korbit AI

Note

This feature is in early access. You can enable or disable it in the Korbit Console.

What change is being made?

Fix the selection behavior when pressing "shift+arrowdown" into a table to ensure the whole table is selected.

Why are these changes being made?

The previous implementation did not correctly handle the selection of table elements when using the "shift+arrowdown" key combination, leading to incomplete or incorrect selections. This fix ensures that the entire table is selected as expected, improving the user experience and consistency of the selection behavior.

Summary by CodeRabbit

• New Features

  • Introduced an automated test to verify the keyboard shortcut for selecting an entire table in the editor.
  • Enhanced focus handling for table selections, improving accuracy when navigating within table structures.

• Bug Fixes

  • Improved robustness of table selection behavior, addressing issues with focus management.

[korbit-ai]

Clone of the PR facebook/lexical#6274

[korbit-ai]

My review is in progress 📖 - I will have feedback for you in a few minutes!

[korbit-ai]

I have reviewed your code and did not find any issues!

---

Please note that I can make mistakes, and you should still encourage your team to review your code as well.

[furwellness]

@coderabbitai review

[coderabbitai]

Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

This update enhances the table selection functionality within the editor by adding a new test case that verifies selecting an entire table using the Shift + ArrowDown shortcut. It also refines the logic for determining focus during table interactions, making the selection process more accurate and robust. Overall, these changes improve user experience by allowing for seamless navigation and selection within tables.

Changes

Files	Change Summary
packages/lexical-playground/__tests__/e2e/Selection.spec.mjs	Added a new test case to verify that using Shift + ArrowDown selects an entire table, with conditions to skip in certain editor states.
packages/lexical-table/src/LexicalTableSelectionHelpers.ts	Updated applyTableHandlers to compute a tableMap for better focus management and selection handling within tables.

Poem

🐇 In the editor's realm, where tables reside,
A new test was born, with logic as guide.
With Shift + ArrowDown, whole tables we claim,
Navigating with ease, it's a delightful game!
So hop with joy, as selections now flow,
In the garden of code, watch the rabbit glow! 🌼✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between e9efd81 and 70a61db.

Files selected for processing (2)

• packages/lexical-playground/tests/e2e/Selection.spec.mjs (1 hunks)
• packages/lexical-table/src/LexicalTableSelectionHelpers.ts (1 hunks)

Additional comments not posted (2)

packages/lexical-playground/__tests__/e2e/Selection.spec.mjs (1)

719-737: Test case for table selection looks good.

The test case effectively verifies the selection behavior when Shift + ArrowDown is used on a table, ensuring the entire table is selected. It aligns with the PR objectives to improve table selection functionality.

packages/lexical-table/src/LexicalTableSelectionHelpers.ts (1)

Line range hint 719-735: Enhanced focus management logic is well-implemented.

The use of tableMap for determining focus in table selections is a robust improvement, allowing for more precise selection handling. This change aligns with the PR objectives to improve table interaction.

Ensure that these changes do not introduce regressions in other parts of the codebase that rely on table selection logic.

[furwellness]

/review

[codiumai-pr-agent-free]

PR Reviewer Guide 🔍

(Review updated until commit 70a61db)

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 PR contains tests

🔒 No security concerns identified

⚡ Key issues to review Code Complexity The addition of multiple lines for handling table map computation and selection focus increases the complexity of the applyTableHandlers function. Consider refactoring to improve readability and maintainability.

[github-actions]

Persistent review updated to latest commit 70a61db

[furwellness]

Zero comments from coderabbit