1.3.0.0 Release #127
Draft
1.3.0.0 Release #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this commit includes:
- Client
- Implemetation of SDK for development of custom providers
- Refactored downloader to support the new contracts/models from the SDK
- Removed configuration in favour of provider based configuration in file
- Refactored command parsing to use cocona instead
- Implemented file based logging for diagnostics
- Removed -r option in get in favour of info command to view gallery information
- Added provider command to view installed providers
- Removed series command (temporarily)
- Provider (asuka.Provider.Nhentai):
- Use restsharp instead of refit due to the breaking change
- Implemented reading from UA.txt and cookie.txt file for the cookies and
user agent instead of configuration from the client.
- Implemented support to read Netscape Navigator Cookie dump and JSON
cookie dump
Rollback to Refit. The performance in downloading while using restsharp is incredibly slow and falling back to refit solves the performance issue. I may wrongly use restsharp though.
This implementation only supports single provider. Future iteration within this branch will allow support of using multiple providers. This commit also bundles changes such as displaying the no provider found in search and recreate provider folder if not found (which fixes an exception throwing when not found)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will contain the following changes:
This list of proposed changes is not yet final.