Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rank loss func bug #14

Open
MLightM opened this issue Jul 28, 2021 · 4 comments
Open

rank loss func bug #14

MLightM opened this issue Jul 28, 2021 · 4 comments

Comments

@MLightM
Copy link

MLightM commented Jul 28, 2021

rank loss should be ''..... - tf.multiply(pre_pw_dif, gt_pw_dif) ...‘’, '-' is missing when define the loss in rank_lstm.py

@fulifeng
Copy link
Owner

fulifeng commented Aug 2, 2021

Come on! Please check the difference when we calculate: pre_pw_dif and gt_pw_dif

@MLightM
Copy link
Author

MLightM commented Aug 2, 2021

Come on! Please check the difference when we calculate: pre_pw_dif and gt_pw_dif

oh... yes, you are right, thanks!

@wjhmike95
Copy link

why do you use "mean" to reduce rank loss instead of "sum" which is from loss equation in the essay?

@ownnaruto
Copy link

Is this loss really useful?I try so many times, just find that the results without rank loss are much better!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants