Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

future function #13

Open
noke8868 opened this issue May 4, 2021 · 1 comment
Open

future function #13

noke8868 opened this issue May 4, 2021 · 1 comment

Comments

@noke8868
Copy link

noke8868 commented May 4, 2021

"we normalize the price of each stock via dividing it by its maximum value throughout the entire 2013-2017 dataset"
in the paper, you used this way to normalize the value. however maximum value during the period is a future function
which can be known after the whole period.
this is very common mistake to use future function, did you try other normlizeing method?
thanks

@fulifeng
Copy link
Owner

Yes, before we use the maximum value throughout the entire 2013-2017 dataset, we have tried to use the maximum value during the training period. The results are quite close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants