Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run coros utility func #1740

Open
wild-endeavor opened this issue Oct 24, 2024 · 3 comments
Open

run coros utility func #1740

wild-endeavor opened this issue Oct 24, 2024 · 3 comments

Comments

@wild-endeavor
Copy link

Hi Team. I'd like to use the run_coros_in_chunks function. I understand there's some callback functionality in there, but can we make it a public function (just no _)? Maybe the public function always just hardcodes the noop callback?

Thank you.

@martindurant
Copy link
Member

This being python, the "_" really means "not designed for end-users". In a library like this one, most people who look at the code are NOT end-users, but developers of other libraries. In this case, it specifically interacts with fsspec's internal loop/thread, so I would want to mark somehow that it's an expert-level function.

just hardcodes the noop callback

NoOpCallback is already the defeault - do youn mean something else?

@wild-endeavor
Copy link
Author

Got it. We're using it to control concurrency in our container (list/dictionary) transformers that trigger i/o. hopefully it won't change?

thank you.

@martindurant
Copy link
Member

It won't change!

You could in theory add a test to this repo which specifically depends on the function location and signature, or make a CI run on your project against this project's master branch for early warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants