Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for option types? #31

Open
isaacabraham opened this issue Oct 20, 2016 · 5 comments
Open

Support for option types? #31

isaacabraham opened this issue Oct 20, 2016 · 5 comments

Comments

@isaacabraham
Copy link

Description

I can't find any support for optional data within the TP - so I'm forced to fall back to working with strings and then converting to e.g. floats.

Have I missed something?

@giuliohome
Copy link

giuliohome commented Feb 7, 2020

See also my workaround #56 (comment)
If the maintainers consider this an enhancement that is not even planned for implementation, they should clearly write that this project is experimental and not ready for production...

@abelbraaksma
Copy link
Member

@giuliohome, since this is open source and I believe it started as a proof of concept for type providers, it's a bit rough on the edges. What this project really needs is some contributors that like to step in. I'm sure you can write a PR (the source of this project isn't that complex).

And personally there are some features I might contribute to myself, for instance the dynamic range selection, or adding discovery of sheetnames. It'd be nice to work together and get some open issues resolved.

@giuliohome
Copy link

Yes, after a quick look at the source I would guess that the point could be around here.

Well, maybe I can write a PR, I'll think about it...

@giuliohome
Copy link

giuliohome commented Dec 1, 2020

Or maybe it's better to discuss the idea before writing any code.

It seems to me that the current code looks at the first row to determine types. One could assume that the template is chosen and modified in order to simplify type inferring, so the easiest idea could be: let's guess the type with the first two rows instead of only one. And let's say that the inferred type is T option when one cell is empty and the other has inferred type T.

Hopefully, this could be enough from my side either if someone else is more ready than me to do the actual code change or if someone else already disagrees with the proposed idea.

@quintusm
Copy link
Collaborator

quintusm commented Dec 1, 2020

HI all.
I am in the process of doing an update to move the code base to FAKE5 and .netstandard only as per the template for type providers. This has proven to take much longer than anticipated and I have had less time to spend on it than I expected.

Once that is done it should be easier to make progress on the core functionality of the project and I will be looking at trying to implement more of the outstanding requests. There is a lot that could be done. In the meantime of course any contributions would be most welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants