Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legend in case of using Name property #144

Open
FoggyFinder opened this issue Nov 25, 2018 · 2 comments
Open

Legend in case of using Name property #144

FoggyFinder opened this issue Nov 25, 2018 · 2 comments

Comments

@FoggyFinder
Copy link

From documentation:

A legend is added automatically when names are used for data sets.

That's incorrect right now.

Probably because

let hasLegend = not (String.IsNullOrEmpty series.Name) || LegendEnabled.IsSome

series.Name is empty since #21

@voronoipotato
Copy link

dce9fec

does this check-in fix this issue?

@FoggyFinder
Copy link
Author

@voronoipotato no.

Probably I wasn't clear enough.

96e4f6c

Name was set to a Chart, but legend's visibility still depends on name of a series.

let hasLegend = not (String.IsNullOrEmpty series.Name) || LegendEnabled.IsSome

So, I see two options here:

  1. Documentation is wrong
  2. hasLegend should check ch.Name instead of series.Name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants