Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow eliding qualification when pattern matching against DUs where type is known #1395

Open
5 of 6 tasks
cmeeren opened this issue Nov 28, 2024 · 0 comments
Open
5 of 6 tasks

Comments

@cmeeren
Copy link

cmeeren commented Nov 28, 2024

I propose we allow eliding module/type qualifications when pattern matching against DUs where the type is known.

Today, for records, F# is smart enough to not require qualifying the type when it knows which type you are matching against:

type A = { X: int }

type B = { X: int }

let f () = { A.X = 1 }

match f () with
| { X = x } -> x

However, this is not the case for DUs. From a dev perspective, I see no reason why I shouldn't be able to do this:

type A = | Case1

type B = | Case1

let f () = A.Case1

match f () with
| Case1 -> ()

However, this fails on Case1 on the last line because it thinks I am pattern matching against B:

image

So currently, we must qualify the case:

match f () with
| A.Case1 -> ()

With longer type names nested inside modules, like SelfAttestedCourseCompletion.CreateError, the pattern matching starts to get fairly verbose.

Interop with active patterns

If there is an active pattern in scope with the same name, that should of course still take precedence.

Pros and Cons

The advantages of making this adjustment to F# are: Consistency with record features, less verbosity without loss of clarity.

The disadvantages of making this adjustment to F# are: None?

Extra information

Estimated cost (XS, S, M, L, XL, XXL): Don't know, maybe S-M?

Related suggestions: (put links to related suggestions here)

Affidavit (please submit!)

Please tick these items by placing a cross in the box:

  • This is not a question (e.g. like one you might ask on StackOverflow) and I have searched StackOverflow for discussions of this issue
  • This is a language change and not purely a tooling change (e.g. compiler bug, editor support, warning/error messages, new warning, non-breaking optimisation) belonging to the compiler and tooling repository
  • This is not something which has obviously "already been decided" in previous versions of F#. If you're questioning a fundamental design decision that has obviously already been taken (e.g. "Make F# untyped") then please don't submit it
  • I have searched both open and closed suggestions on this site and believe this is not a duplicate

Please tick all that apply:

  • This is not a breaking change to the F# language design
  • I or my company would be willing to help implement and/or test this

For Readers

If you would like to see this issue implemented, please click the 👍 emoji on this issue. These counts are used to generally order the suggestions by engagement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant