Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use NuGet PackageReferences by default for Bolero.Templates #10

Closed
ctaggart opened this issue May 16, 2019 · 3 comments
Closed

use NuGet PackageReferences by default for Bolero.Templates #10

ctaggart opened this issue May 16, 2019 · 3 comments

Comments

@ctaggart
Copy link

When getting started at https://fsbolero.io/ dotnet new -i Bolero.Templates creates a project that requires paket. I don't use paket any more and strongly prefer working with the build in NuGet package references. It supports transitive dependencies. It supports locking with the latest version as well. It works better with other dotnet tooling like dotnet publish and friends.

I'm creating this issue because I'm not the only one that hit this stumbling block: https://fsharp.slack.com/archives/C10DLSHQV/p1557920194474300

Although I'd prefer to see this project use NuGet packages as well, this request is for the templates, not quite the same as fsbolero/Bolero#43 .

@BentTranberg
Copy link

Just now found this: https://forums.websharper.com/topic/86603

This seems to be on Mono. I tried on Win10 when I failed to convert the template project to NuGet at first attempt. If I understand correctly, the solution is to add the following to the project when converting to NuGet:

<PackageReference Include="Blazor.Extensions.SignalR" Version="0.1.8" />

I understand this is perhaps slightly off topic, but thought the information might be of use here.

@Tarmil Tarmil transferred this issue from fsbolero/Bolero May 21, 2019
@Tarmil
Copy link
Member

Tarmil commented May 21, 2019

(Moving the issue to the Template repo)

For the template, I've now come to agree that it should use plain NuGet by default. Especially now that, for people who prefer Paket, @thinkbeforecoding's paket.install makes the conversion pretty painless, you just need to run:

paket.install && .paket/paket convert-from-nuget --force

We could provide a --paket option that would run the above as a post-create script (using a locally installed paket.install ofc).

@ctaggart
Copy link
Author

Just saw https://twitter.com/fsbolero/status/1134103050149355520 with Bolero 0.5 released!

Looks like this was fixed by 2e59b9c

Nice, dotnet new bolero-app produced this for the client:

<?xml version="1.0" encoding="utf-8"?>
<Project Sdk="Microsoft.NET.Sdk.Web">
  <PropertyGroup>
    <TargetFramework>netstandard2.0</TargetFramework>
  </PropertyGroup>
  <ItemGroup>
    <Compile Include="Main.fs" />
    <Compile Include="Startup.fs" />
  </ItemGroup>
  <ItemGroup>
    <PackageReference Include="Bolero" Version="0.5.28-preview*" />
    <PackageReference Include="Bolero.Build" Version="0.5.28-preview*" />
    <PackageReference Include="Bolero.HotReload" Version="0.5.28-preview*" />
    <PackageReference Include="Microsoft.AspNetCore.Blazor.Build" Version="3.0-preview5-*" />
    <PackageReference Include="Microsoft.AspNetCore.Blazor.DevServer" Version="3.0-preview5-*" />
  </ItemGroup>
</Project>

And this for the server:

<?xml version="1.0" encoding="utf-8"?>
<Project Sdk="Microsoft.NET.Sdk.Web">
  <PropertyGroup>
    <TargetFramework>netcoreapp3.0</TargetFramework>
  </PropertyGroup>
  <ItemGroup>
    <Compile Include="Startup.fs" />
  </ItemGroup>
  <ItemGroup>
    <ProjectReference Include="..\ShinyToy.Client\ShinyToy.Client.fsproj" />
    <PackageReference Include="Bolero.Server" Version="0.5.28-preview*" />
    <PackageReference Include="Microsoft.AspNetCore.Blazor.Server" Version="3.0-preview5-*" />
  </ItemGroup>
</Project>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants