Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Custom scalar type #211

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

EgorBarakhov
Copy link

Summary

Add type SquishedString useful for emails and personal info in forms

How it works

image

Test plan

List of steps to manually test introduced functionality:

  • Open GraphiQL App
  • Authenticate yourself
  • Make request using schema:
mutation {
  updateUser(input: {
    email: "  [email protected]	"
    firstName: "				Robert				"
    lastName : "		Downey 		Jr.			"
  }) {
    me {
      email
      firstName
      lastName
    }
  }
}

Review notes

While reviewing pull-request (especially when it's your pull-request),
please make sure that:

  • you understand what problem is solved by PR and how is it solved
  • new tests are in place, no redundant tests
  • DB schema changes reflect new migrations
  • newly introduced DB fields have indexes and constraints
  • there are no missed files (migrations, view templates)
  • required ENV variables added and described in .env.example and added to Heroku
  • associated Heroku review app works correctly with introduced changes

Deploy notes

N/A

References

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Custom scalar types
2 participants