Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLIENT] Convert sessions controller to a service #196

Closed
ultimatemonty opened this issue Aug 4, 2016 · 2 comments
Closed

[CLIENT] Convert sessions controller to a service #196

ultimatemonty opened this issue Aug 4, 2016 · 2 comments

Comments

@ultimatemonty
Copy link
Member

Using controllers for most things is now considered bad practice. Using the controller needs API is considered an offense punishable by extreme Twitter shaming.

Let's not be shamed and instead convert the sessions controller to a service.
@gschorkopf
Copy link
Member

👍 Additionally, might be worthwhile to just go forth with #152

@ultimatemonty
Copy link
Member Author

@gschorkopf agreed. I'll close this in favor of #152

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gschorkopf @ultimatemonty