Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add explicit checks for node serialisation. #19

Open
fizikarubi opened this issue Mar 2, 2023 · 0 comments
Open

Add explicit checks for node serialisation. #19

fizikarubi opened this issue Mar 2, 2023 · 0 comments
Assignees
@fizikarubi

Comments

@fizikarubi
Copy link
Collaborator

Currently the node serialisation logic doesn't handle errors when the child node hashes are:

left: Default, right: Default
left: Database, right: _
left: _, right: Database

While the node insertion logic prevents such cases, it would be better to add explicit checks for more robustness.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fizikarubi fizikarubi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fizikarubi