Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependent: :destroy to Spree::Order#friendly_promotions #12

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

mamhoff
Copy link
Contributor

@mamhoff mamhoff commented Oct 4, 2023

This is the same change as in
solidusio/solidus#5411

Copy link
Collaborator

@davecandlescience davecandlescience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still find it amusing that this bug has been around so long.

@mamhoff mamhoff merged commit caa1b74 into main Oct 4, 2023
mamhoff added a commit that referenced this pull request Jul 1, 2024
…endly-order-promotions

Add dependent: :destroy to Spree::Order#friendly_promotions
mamhoff added a commit that referenced this pull request Oct 25, 2024
…endly-order-promotions

Add dependent: :destroy to Spree::Order#friendly_promotions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants