Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typestack/typedi compatibility layer proposal #160

Open
1 task
freshgum-bubbles opened this issue Mar 26, 2024 · 2 comments · May be fixed by #189
Open
1 task

typestack/typedi compatibility layer proposal #160

freshgum-bubbles opened this issue Mar 26, 2024 · 2 comments · May be fixed by #189
Assignees
Labels
enhancement New feature or request

Comments

@freshgum-bubbles
Copy link
Owner

Compatibility layer with typestack/typedi

#158 essentially proposes a compatibility layer which allows the usage of ++ in places where typestack's implementation is expected.

I definitely think this is worth exploring; it's not a use-case I originally considered,
but I do think it would expand the horizons of where ++ could be used.

A wise investment would be creating a list of incompatibilities with source.
Let's do that here.

  • xxx

General compatibility with typestack

Compatibility with typestack has been a bit of a bug bear of mine.
I've been meaning to make it easier to migrate to this one.
I can only imagine the work required to have to migrate at-once; this could definitely be made easier.

@freshgum-bubbles freshgum-bubbles self-assigned this Mar 26, 2024
@freshgum-bubbles freshgum-bubbles added the enhancement New feature or request label Mar 26, 2024
@freshgum-bubbles freshgum-bubbles moved this to Todo in Version 1! Mar 26, 2024
@freshgum-bubbles freshgum-bubbles moved this from Todo to In progress in Version 1! May 11, 2024
@intellix
Copy link

would this mean addressing the doubled references? #152 - then we could swap the dependency and we're done. Right now it would be a huge effort for us to go through every file and double up the references everywhere

@freshgum-bubbles
Copy link
Owner Author

would this mean addressing the doubled references? #152 - then we could swap the dependency and we're done. Right now it would be a huge effort for us to go through every file and double up the references everywhere

Yes, that would be supported. I'm aiming for 1:1 compatibility with typestack's implementation, where it's just a matter of swapping the typedi import with @freshgum/typedi/contrib/....

The ContainerInstance implementation is partially completed, alongside that of ContainerRegistry.

Note that I'm still working on this suite: it's going to be a moderately large effort, as I'd like to get my implementation to pass typestack's test suite (which means importing https://github.com/typestack/typedi as a submodule and applying a .patch for the test files' imports.)

@freshgum-bubbles freshgum-bubbles linked a pull request Jun 27, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: In progress
Development

Successfully merging a pull request may close this issue.

2 participants