Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPM Release and Typescript Support #13

Open
michaelcmelton opened this issue Jul 6, 2021 · 8 comments
Open

NPM Release and Typescript Support #13

michaelcmelton opened this issue Jul 6, 2021 · 8 comments
Labels
enhancement New feature or request

Comments

@michaelcmelton
Copy link

Is there current Typescript Support and NPM packages for this library?

@jwdunn1 jwdunn1 added the enhancement New feature or request label Jul 7, 2021
@jwdunn1
Copy link
Member

jwdunn1 commented Jul 7, 2021

Not yet. Perhaps NPM packaging sooner than Typescript support. I'll mark this as an enhancement.

@michaelcmelton
Copy link
Author

Are you open to contributions? If so, I'd be glad to try and help with these things when I've got some free time.

@jwdunn1
Copy link
Member

jwdunn1 commented Jul 7, 2021

Yes, this library is open to contributions! When you get the opportunity, feel free to fork, update, test, and create a pull request.

@michaelcmelton
Copy link
Author

@jwdunn1 Do you have any contact info I can reach you at? I want to run a few things by you before I begin really digging in.

@asukaminato0721
Copy link
Contributor

https://github.com/wuyudi/p5.EasyCam/blob/try2ts/dist/p5.easycam.d.ts

I spent some time to adopt it into ts and generate a .d.ts file. Hope it may help.

Some types are not clear to me, so I write any instead.

I don't know whether this can be a PR (ts to js is a huge difference).

@jwdunn1
Copy link
Member

jwdunn1 commented Dec 12, 2022

@wuyudi Excellent! Thank you for the time spent on this. If you want to create a PR, please rename or drop the dist folder - it may be misunderstood as a distribution folder.

@jwdunn1
Copy link
Member

jwdunn1 commented Apr 18, 2023

NPM package published.
[ It took more than one year to resolve the request for control of the name "p5.easycam" on npm! ]

@jwdunn1
Copy link
Member

jwdunn1 commented Apr 19, 2023

The TypeScript version of the code is v1.2.0. This is not aligned with the current release version 1.2.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants