Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

class vs characterClass ? #24

Open
wnm opened this issue Jan 17, 2017 · 1 comment
Open

class vs characterClass ? #24

wnm opened this issue Jan 17, 2017 · 1 comment
Labels
Milestone

Comments

@wnm
Copy link

wnm commented Jan 17, 2017

Hi there,

I'm building a resume tool, and want to support export to json (with FRESH schema).

In your schema definition, there is a field called class in the info section:
https://github.com/fresh-standard/FRESCA/blob/master/schema/fresh-resume-schema.json#L47

In your example, that field is called characterClass:
https://github.com/fluentdesk/jane-q-fullstacker/blob/master/resume/jane-resume.json#L12

Which one should I use?

Thanks!

@hacksalot
Copy link
Member

hacksalot commented Jan 25, 2018

This is an optional field, but the schema says class so it should be class. But virtually every example uses characterClass. Beyond that, class may not be the right descriptor. But the examples should agree with the schema, whatever the case.

@hacksalot hacksalot added the bug label Jan 25, 2018
@hacksalot hacksalot added this to the 1.0.0-beta.2 milestone Feb 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants