Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Night mode gone since v12.4.0 #97

Open
1977er opened this issue Jan 25, 2024 · 3 comments
Open

Night mode gone since v12.4.0 #97

1977er opened this issue Jan 25, 2024 · 3 comments

Comments

@1977er
Copy link

1977er commented Jan 25, 2024

Expected Behavior

In v12.3.0 the config (see below) kicks in the dark mode. Black background, inverted textcolors etc.

Current Behavior

Since v12.4.0 this does not work anymore. The normal light mode css stuff is used.

Steps to Reproduce

My config looks like this:

{
    "mapLayers": [
      {
        "config": {
          "mode": "night",
  1. use mode: night in one of your mapLayers
  2. reload the website and switch to the given mapLayer

Context

Your Environment

  • Version used: v12.4.0
  • Browser Name and version: LibreWolf v120.0-1
  • Operating System and version (desktop or mobile): macOS 14.2.1
  • Link to your project: https://hannover.freifunk.net/friedhof/ (irrelevant, since I reverted back to v12.3.0

Screenshots

@maurerle
Copy link
Member

@MyIgel @weeman1337 could you have a look at this please? :)

@maurerle
Copy link
Member

One could also add a watch to window.matchMedia("(prefers-color-scheme: dark)"); when fixing this, so that one can have mode: auto in the config as well

@genofire
Copy link

genofire commented Nov 26, 2024

Was removed here:

860cdd9#diff-0eb547304658805aad788d320f10bf1f292797b5e6d745a3bf617584da017051L28


i believe a window.matchMedia("(prefers-color-scheme: dark)") should switch the layer to a mode with night ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants