Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sanity checks for malicious challenges #1

Closed
TheZ3ro opened this issue Jan 17, 2023 · 3 comments
Closed

Add sanity checks for malicious challenges #1

TheZ3ro opened this issue Jan 17, 2023 · 3 comments

Comments

@TheZ3ro
Copy link
Collaborator

TheZ3ro commented Jan 17, 2023

Right now we don't perform any sanity checks on challenges coming from the server.
This is obviously bad but it's a PoC and we like to be brave.

This issue is a reminder to add some kind of checks (or to add a comment to remind that we should eventually add checks) at line https://github.com/lsd-cat/securedrop-poc/blob/main/source.py#L68

@TheZ3ro
Copy link
Collaborator Author

TheZ3ro commented Jan 24, 2023

This is still a valid issue even though line number reported by OP is not meaningful anymore

@lsd-cat
Copy link
Member

lsd-cat commented Dec 22, 2023

This should no longer apply as we phased out the use of inverted keys and the client does not send anymore a "response" to the challenges, rather decryption happens locally.

@lsd-cat
Copy link
Member

lsd-cat commented Jan 23, 2024

Confirmed the assessment, this issue is no longer applicable thanks to the protocol contribution from @eaon and the subsequent merging of #17.

@lsd-cat lsd-cat closed this as completed Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants