From 39fe539b2e271e6ebd384ac13309698f3b5e5370 Mon Sep 17 00:00:00 2001 From: deeplow Date: Wed, 11 Oct 2023 15:31:45 +0100 Subject: [PATCH] Mirror RELEASE.md text in qa.py qa.py should be in sync with RELEASE.md, or else it fails with $ ./dev_scripts/qa.py --check-refs This was accidentally introduced in https://github.com/freedomofpress/dangerzone/pull/583/files --- dev_scripts/qa.py | 24 ++++++++++++++++++++++-- 1 file changed, 22 insertions(+), 2 deletions(-) diff --git a/dev_scripts/qa.py b/dev_scripts/qa.py index bdca095d1..58682d4a7 100755 --- a/dev_scripts/qa.py +++ b/dev_scripts/qa.py @@ -92,6 +92,8 @@ #### 3. Dangerzone successfully installs the container image +_(Not for Qubes)_ + Remove the Dangerzone container image from Docker/Podman. Then run Dangerzone. Danerzone should install the container image successfully. @@ -107,6 +109,9 @@ Dangerzone should fail gracefully, by reporting that the operation failed, and showing the last error message. +_(Only for Qubes)_ The only message that the user should see is: "The document +format is not supported", without any untrusted strings. + #### 6. Dangerzone succeeds in converting multiple documents Run Dangerzone against a list of documents, and tick all options. Ensure that: @@ -114,7 +119,7 @@ * Attempting to close the window while converting asks the user if they want to abort the conversions. * Conversions are completed successfully. -* Conversions show individual progress. +* Conversions show individual progress in real-time (double-check for Qubes). * _(Only for Linux)_ The resulting files open with the PDF viewer of our choice. * OCR seems to have detected characters in the PDF files. * The resulting files have been saved with the proper suffix, in the proper @@ -135,7 +140,22 @@ Go to a directory with office documents, right-click on one, and click on "Open With". We should be able to open the file with Dangerzone, and then convert it. -#### 9. Updating Dangerzone handles external state correctly. +#### 9. Dangerzone shows helpful errors for setup issues on Qubes + +_(Only for Qubes)_ + +Check what errors does Dangerzone throw in the following scenarios. The errors +should point the user to the Qubes notifications in the top-right corner: + +1. The `dz-dvm` template does not exist. We can trigger this scenario by + temporarily renaming this template. +2. The Dangerzone RPC policy does not exist. We can trigger this scenario by + temporarily renaming the `dz.Convert` policy. +3. The `dz-dvm` disposable Qube cannot start due to insufficient resources. We + can trigger this scenario by temporarily increasing the minimum required RAM + of the `dz-dvm` template to more than the available amount. + +#### 10. Updating Dangerzone handles external state correctly. _(Applies to Linux/Windows/MacOS. For MacOS/Windows, it requires an installer for the new version)_