-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
screen disabled when loading radeonkms.ko with SUMO chip #66
Comments
Could you before loading the module do : Thanks. |
Well, this didn't give any more output as far as I could see, but it made me yet another time look very closely at the logs, and this time I noticed this peculiarity from the log of the old, working version: So, I tried setting Now, is this still considered a bug? I'm fine with just closing it (and pretty happy). |
We default to hw_i2c=0 in 2e424b6 |
…otg master When booting the system with DCN401, the driver adds the following dmesg warning: WARNING: CPU: 8 PID: 175 at drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_resource.c:1923 resource_get_opp_heads_for_otg_master+0x13/0x70 [amdgpu] Modules linked in: amdgpu(+) hid_generic amdxcp i2c_algo_bit drm_ttm_helper ttm drm_exec gpu_sched drm_suballoc_helper drm_buddy drm_display_helper drm_kms_helper usbhid hid drm i2c_piix4 ahci igc libahci video wmi CPU: 8 PID: 175 Comm: systemd-udevd Not tainted 6.8.0-EXTRA-PROMO-MAY-29+ freebsd#66 Hardware name: ASUS System Product Name/TUF GAMING X570-PRO (WI-FI), BIOS 4021 08/10/2021 RIP: 0010:resource_get_opp_heads_for_otg_master+0x13/0x70 [amdgpu] Code: 8b 66 0f 1f 44 00 00 90 90 90 90 90 90 90 90 90 90 90 90 90 90 90 90 0f 1f 44 00 00 55 48 83 bf f8 07 00 00 00 48 89 e5 74 0c <0f> 0b 31 f6 89 f0 5d e9 0c 65 01 e5 48 83 bf e0 07 00 00 00 75 ea RSP: 0018:ffffa5f000816ed8 EFLAGS: 00010246 [...] PKRU: 55555554 Call Trace: <TASK> ? show_regs+0x65/0x70 ? __warn+0x85/0x160 ? resource_get_opp_heads_for_otg_master+0x13/0x70 [amdgpu] ? report_bug+0x192/0x1c0 ? handle_bug+0x44/0x90 ? exc_invalid_op+0x18/0x70 [...] This warning is triggered by a check in the function resource_get_opp_heads_for_otg_master that validates if the request operation is in a master OTG pipe; if not, the warning above is displayed. In other words, another part of the code might be calling this function in a non-OTG master pipe context, resulting in the log message. The reason the ASSERT was triggered is that the current state wasn't updated after applying the context to the hardware. This means that the update_dsc_for_odm_change might be called from a non-OTG-MASTER. To prevent this, it's crucial to check if the current reference is pointing to an OTG master before operate in the old OTG master reference. If it's not, the function must set the old OTG reference to NULL and avoid calling resource_get_opp_heads_for_otg_master before the context is updated. Reviewed-by: Wenjing Liu <[email protected]> Acked-by: Hamza Mahfooz <[email protected]> Co-developed-by: Wenjing Liu <[email protected]> Signed-off-by: Wenjing Liu <[email protected]> Signed-off-by: Rodrigo Siqueira <[email protected]> Signed-off-by: Alex Deucher <[email protected]>
…otg master When booting the system with DCN401, the driver adds the following dmesg warning: WARNING: CPU: 8 PID: 175 at drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_resource.c:1923 resource_get_opp_heads_for_otg_master+0x13/0x70 [amdgpu] Modules linked in: amdgpu(+) hid_generic amdxcp i2c_algo_bit drm_ttm_helper ttm drm_exec gpu_sched drm_suballoc_helper drm_buddy drm_display_helper drm_kms_helper usbhid hid drm i2c_piix4 ahci igc libahci video wmi CPU: 8 PID: 175 Comm: systemd-udevd Not tainted 6.8.0-EXTRA-PROMO-MAY-29+ freebsd#66 Hardware name: ASUS System Product Name/TUF GAMING X570-PRO (WI-FI), BIOS 4021 08/10/2021 RIP: 0010:resource_get_opp_heads_for_otg_master+0x13/0x70 [amdgpu] Code: 8b 66 0f 1f 44 00 00 90 90 90 90 90 90 90 90 90 90 90 90 90 90 90 90 0f 1f 44 00 00 55 48 83 bf f8 07 00 00 00 48 89 e5 74 0c <0f> 0b 31 f6 89 f0 5d e9 0c 65 01 e5 48 83 bf e0 07 00 00 00 75 ea RSP: 0018:ffffa5f000816ed8 EFLAGS: 00010246 [...] PKRU: 55555554 Call Trace: <TASK> ? show_regs+0x65/0x70 ? __warn+0x85/0x160 ? resource_get_opp_heads_for_otg_master+0x13/0x70 [amdgpu] ? report_bug+0x192/0x1c0 ? handle_bug+0x44/0x90 ? exc_invalid_op+0x18/0x70 [...] This warning is triggered by a check in the function resource_get_opp_heads_for_otg_master that validates if the request operation is in a master OTG pipe; if not, the warning above is displayed. In other words, another part of the code might be calling this function in a non-OTG master pipe context, resulting in the log message. The reason the ASSERT was triggered is that the current state wasn't updated after applying the context to the hardware. This means that the update_dsc_for_odm_change might be called from a non-OTG-MASTER. To prevent this, it's crucial to check if the current reference is pointing to an OTG master before operate in the old OTG master reference. If it's not, the function must set the old OTG reference to NULL and avoid calling resource_get_opp_heads_for_otg_master before the context is updated. Reviewed-by: Wenjing Liu <[email protected]> Acked-by: Hamza Mahfooz <[email protected]> Co-developed-by: Wenjing Liu <[email protected]> Signed-off-by: Wenjing Liu <[email protected]> Signed-off-by: Rodrigo Siqueira <[email protected]> Signed-off-by: Alex Deucher <[email protected]>
Describe the bug
Loading
radeonkms.ko
disables the screen with error message[drm] Cannot find any crtc or sizes
FreeBSD version
FreeBSD 13.0-RC2 #11 releng/13.0-n244684-13c22f74953: Fri Mar 12 09:49:28 CET 2021
PCI Info
pciconf -lv
hostb0@pci0:0:0:0: class=0x060000 card=0x17051849 chip=0x17051022 rev=0x00 hdr=0x00
vendor = 'Advanced Micro Devices, Inc. [AMD]'
device = 'Family 12h Processor Root Complex'
class = bridge
subclass = HOST-PCI
vgapci0@pci0:0:1:0: class=0x030000 card=0x96401849 chip=0x964a1002 rev=0x00 hdr=0x00
vendor = 'Advanced Micro Devices, Inc. [AMD/ATI]'
device = 'Sumo [Radeon HD 6530D]'
class = display
subclass = VGA
hdac0@pci0:0:1:1: class=0x040300 card=0x17141849 chip=0x17141002 rev=0x00 hdr=0x00
vendor = 'Advanced Micro Devices, Inc. [AMD/ATI]'
device = 'BeaverCreek HDMI Audio [Radeon HD 6500D and 6400G-6600G series]'
class = multimedia
subclass = HDA
pcib1@pci0:0:4:0: class=0x060400 card=0x12341022 chip=0x17091022 rev=0x00 hdr=0x01
vendor = 'Advanced Micro Devices, Inc. [AMD]'
device = 'Family 12h Processor Root Port'
class = bridge
subclass = PCI-PCI
xhci0@pci0:0:16:0: class=0x0c0330 card=0x78121849 chip=0x78121022 rev=0x03 hdr=0x00
vendor = 'Advanced Micro Devices, Inc. [AMD]'
device = 'FCH USB XHCI Controller'
class = serial bus
subclass = USB
xhci1@pci0:0:16:1: class=0x0c0330 card=0x78121849 chip=0x78121022 rev=0x03 hdr=0x00
vendor = 'Advanced Micro Devices, Inc. [AMD]'
device = 'FCH USB XHCI Controller'
class = serial bus
subclass = USB
ahci0@pci0:0:17:0: class=0x010601 card=0x78001849 chip=0x78011022 rev=0x40 hdr=0x00
vendor = 'Advanced Micro Devices, Inc. [AMD]'
device = 'FCH SATA Controller [AHCI mode]'
class = mass storage
subclass = SATA
ohci0@pci0:0:18:0: class=0x0c0310 card=0x78071849 chip=0x78071022 rev=0x11 hdr=0x00
vendor = 'Advanced Micro Devices, Inc. [AMD]'
device = 'FCH USB OHCI Controller'
class = serial bus
subclass = USB
ehci0@pci0:0:18:2: class=0x0c0320 card=0x78081849 chip=0x78081022 rev=0x11 hdr=0x00
vendor = 'Advanced Micro Devices, Inc. [AMD]'
device = 'FCH USB EHCI Controller'
class = serial bus
subclass = USB
ohci1@pci0:0:19:0: class=0x0c0310 card=0x78071849 chip=0x78071022 rev=0x11 hdr=0x00
vendor = 'Advanced Micro Devices, Inc. [AMD]'
device = 'FCH USB OHCI Controller'
class = serial bus
subclass = USB
ehci1@pci0:0:19:2: class=0x0c0320 card=0x78081849 chip=0x78081022 rev=0x11 hdr=0x00
vendor = 'Advanced Micro Devices, Inc. [AMD]'
device = 'FCH USB EHCI Controller'
class = serial bus
subclass = USB
intsmb0@pci0:0:20:0: class=0x0c0500 card=0x780b1849 chip=0x780b1022 rev=0x13 hdr=0x00
vendor = 'Advanced Micro Devices, Inc. [AMD]'
device = 'FCH SMBus Controller'
class = serial bus
subclass = SMBus
atapci0@pci0:0:20:1: class=0x01018a card=0x780c1849 chip=0x780c1022 rev=0x00 hdr=0x00
vendor = 'Advanced Micro Devices, Inc. [AMD]'
device = 'FCH IDE Controller'
class = mass storage
subclass = ATA
hdac1@pci0:0:20:2: class=0x040300 card=0x88921849 chip=0x780d1022 rev=0x01 hdr=0x00
vendor = 'Advanced Micro Devices, Inc. [AMD]'
device = 'FCH Azalia Controller'
class = multimedia
subclass = HDA
isab0@pci0:0:20:3: class=0x060100 card=0x780e1849 chip=0x780e1022 rev=0x11 hdr=0x00
vendor = 'Advanced Micro Devices, Inc. [AMD]'
device = 'FCH LPC Bridge'
class = bridge
subclass = PCI-ISA
pcib2@pci0:0:20:4: class=0x060401 card=0x00000000 chip=0x780f1022 rev=0x40 hdr=0x01
vendor = 'Advanced Micro Devices, Inc. [AMD]'
device = 'FCH PCI Bridge'
class = bridge
subclass = PCI-PCI
ohci2@pci0:0:20:5: class=0x0c0310 card=0x78091849 chip=0x78091022 rev=0x11 hdr=0x00
vendor = 'Advanced Micro Devices, Inc. [AMD]'
device = 'FCH USB OHCI Controller'
class = serial bus
subclass = USB
pcib3@pci0:0:21:0: class=0x060400 card=0x00001022 chip=0x43a01022 rev=0x00 hdr=0x01
vendor = 'Advanced Micro Devices, Inc. [AMD]'
device = 'Hudson PCI to PCI bridge (PCIE port 0)'
class = bridge
subclass = PCI-PCI
pcib4@pci0:0:21:3: class=0x060400 card=0x00001022 chip=0x43a31022 rev=0x00 hdr=0x01
vendor = 'Advanced Micro Devices, Inc. [AMD]'
device = 'Hudson PCI to PCI bridge (PCIE port 3)'
class = bridge
subclass = PCI-PCI
hostb1@pci0:0:24:0: class=0x060000 card=0x00000000 chip=0x17001022 rev=0x43 hdr=0x00
vendor = 'Advanced Micro Devices, Inc. [AMD]'
device = 'Family 12h/14h Processor Function 0'
class = bridge
subclass = HOST-PCI
hostb2@pci0:0:24:1: class=0x060000 card=0x00000000 chip=0x17011022 rev=0x00 hdr=0x00
vendor = 'Advanced Micro Devices, Inc. [AMD]'
device = 'Family 12h/14h Processor Function 1'
class = bridge
subclass = HOST-PCI
hostb3@pci0:0:24:2: class=0x060000 card=0x00000000 chip=0x17021022 rev=0x00 hdr=0x00
vendor = 'Advanced Micro Devices, Inc. [AMD]'
device = 'Family 12h/14h Processor Function 2'
class = bridge
subclass = HOST-PCI
hostb4@pci0:0:24:3: class=0x060000 card=0x00000000 chip=0x17031022 rev=0x00 hdr=0x00
vendor = 'Advanced Micro Devices, Inc. [AMD]'
device = 'Family 12h/14h Processor Function 3'
class = bridge
subclass = HOST-PCI
hostb5@pci0:0:24:4: class=0x060000 card=0x00000000 chip=0x17041022 rev=0x00 hdr=0x00
vendor = 'Advanced Micro Devices, Inc. [AMD]'
device = 'Family 12h/14h Processor Function 4'
class = bridge
subclass = HOST-PCI
hostb6@pci0:0:24:5: class=0x060000 card=0x00000000 chip=0x17181022 rev=0x00 hdr=0x00
vendor = 'Advanced Micro Devices, Inc. [AMD]'
device = 'Family 12h/14h Processor Function 6'
class = bridge
subclass = HOST-PCI
hostb7@pci0:0:24:6: class=0x060000 card=0x00000000 chip=0x17161022 rev=0x00 hdr=0x00
vendor = 'Advanced Micro Devices, Inc. [AMD]'
device = 'Family 12h/14h Processor Function 5'
class = bridge
subclass = HOST-PCI
hostb8@pci0:0:24:7: class=0x060000 card=0x00000000 chip=0x17191022 rev=0x00 hdr=0x00
vendor = 'Advanced Micro Devices, Inc. [AMD]'
device = 'Family 12h/14h Processor Function 7'
class = bridge
subclass = HOST-PCI
none0@pci0:1:0:0: class=0x048000 card=0x00016902 chip=0x6178544d rev=0x00 hdr=0x00
vendor = 'TBS Technologies'
device = 'DVB Tuner PCIe Card'
class = multimedia
re0@pci0:4:0:0: class=0x020000 card=0x81681849 chip=0x816810ec rev=0x06 hdr=0x00
vendor = 'Realtek Semiconductor Co., Ltd.'
device = 'RTL8111/8168/8411 PCI Express Gigabit Ethernet Controller'
class = network
subclass = ethernet
DRM KMOD version
drm-fbsd13-kmod 5.4.92.g20210202
To Reproduce
kldload radeonkms
Additional context
I had the same problem already with
drm-fbsd12.0-kmod
on any 12.x RELEASE, see also FreeBSD PR #237223.Back then, I tried building a branch using DRM from Linux 5.0, which successfully set the mode on the console at least, see this issue: FreeBSDDesktop/kms-drm#195 -- so I assumed the problem would be gone with newer DRM versions.
For 12.x, my workaround was to still use
drm-fbsd11.2-kmod
(which built and worked with just minor modifications). Unfortunately, it doesn't build any more on 13, so I'm at a dead end here.Here's the log from loading
radeonkms.ko
on 13.0-RC2:For comparison, here's the log when loading
radeonkms.ko
fromdrm-fbsd11.2-kmod
on FreeBSD 12.2-RELEASE-p3:It's interesting that it always complains about not being able to load firmware…
The text was updated successfully, but these errors were encountered: