-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: error at color-system story #378
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR.
There are a couple of issues with the changes that I don't think we can merge as-is:
colors.css
still exists, and its import aren't updated.- We are using globally-scoped stylesheets in the codebase, if we are changing this to a module, other stylesheets should follow.
- We would like to understand the root cause of the issue (whether this is an issue in the repo setup or in the storybook setup) in order to update the config accordingly.
i have impression that problem is not the storybook, |
is the PR is blocked? |
Yes. The changes haven't addressed my concerns in #378 (review). |
not sure why, but things start working after renaming
color.css
tocolors.module.css
:Update index.md
)Closes #66