New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make names of config options for min and max speed more explicit #7

Open

frederikheld opened this issue May 17, 2020 · 0 comments

Labels

arduino module-drivetrain

Owner

frederikheld commented May 17, 2020

Now:

#define SPEED_NOMINAL_MAX 100 // max value of "speed nominal"
#define SPEED_NOMINAL_MIN -100 // min value of "speed nominal"

What SPEED_NOMINAL_MIN actually means is "max speed in reversed direction"!

Therefore change names to:

#define SPEED_NOMINAL_MAX_FWD 100 // max value of "speed nominal" in forward direction
#define SPEED_NOMINAL_MAX_REV 100 // min value of "speed nominal" in reverse direction

The value sent for reverse speeds should still be negative to have a fallback if the information for nominal direction wasn't transmitted correctly.

frederikheld added arduino module-drivetrain labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment