Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't decode entities #5

Open
freddyb opened this issue Apr 25, 2013 · 1 comment
Open

don't decode entities #5

freddyb opened this issue Apr 25, 2013 · 1 comment
Labels
bug

Comments

@freddyb
Copy link
Owner

freddyb commented Apr 25, 2013

as per gareth's comments on twitter https://twitter.com/garethheyes/status/327362562444382208, we should not decode entities.
@freddyb
Copy link
Owner Author

freddyb commented Sep 29, 2014

Test case: <'&lt;/script>&lt;img src=1 onerror=alert(1)>'>
Explanation: "if you are rewriting to code that mutates it's a problem regardless if it's a sandbox or not."

Solution: Don't decode entities? https://developer.mozilla.org/en-US/docs/Web/API/NodeIterator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@freddyb and others