Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow operator to spin intake wheels while pinching/releasing intake #3

Open
nathan815 opened this issue Feb 20, 2018 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@nathan815
Copy link
Member

nathan815 commented Feb 20, 2018

The commands for raising/lowering and pinching/releasing the intake never return true in isFinished. I think this is the reason they remain active and the operator control doesn't allow both at the same time. We need to change this so the intake wheels can be spun up before or while pinching/releasing the intake. I think simply returning true in the commands' isFinished methods will work because as long as execute is ran once it's fine (the solenoid only needs to be set once).

@nathan815 nathan815 added the enhancement New feature or request label Feb 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant