Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classifier Export: Trigger a "Save as" Dialogue #10

Open
jluethi opened this issue Feb 11, 2022 · 3 comments
Open

Classifier Export: Trigger a "Save as" Dialogue #10

jluethi opened this issue Feb 11, 2022 · 3 comments

Comments

@jluethi
Copy link
Collaborator

jluethi commented Feb 11, 2022

Currently it's a text field where the user enters the full file path and it contains a reasonable default.
Better: When the user clicks the export button, trigger a "save as" dialogue, where the user can interactively select the destination and set the filename in the typical interface for a given operating system

@MaksHess
Copy link
Collaborator

Cool idea, this would also allow easy access to multiple versions of the same classifier :)

@jluethi
Copy link
Collaborator Author

jluethi commented Feb 11, 2022

Bildschirmfoto 2022-02-11 um 22 05 23

It's not the prettiest implementation, but it works :)

If the user specifies a new save as path, the classifier is renamed and save in this new location.
Some funny edge cases still when it's not in the current working directory, as the classifier name currently is just the filename, not the full path. Will be doing a small refactor of that, then it should be ready

@jluethi
Copy link
Collaborator Author

jluethi commented Feb 11, 2022

Ok, fixed the saving now so it respects the directory a user is putting it in.

One limitation of the current implementation: If the user clicks "select file" and chooses a new file location, then confirms this in the pop up box, that does not save the file yet. This only confirms the new path. The user needs to click "Save Classifier".

I have not figured out a way to have the select file action actually trigger the saving, which may be confusing to the user, because the automatically generated file selection window says "save" as a confirmation...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants