Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rtl codes signal problems #103

Open
crizy opened this issue Jan 2, 2025 · 4 comments
Open

rtl codes signal problems #103

crizy opened this issue Jan 2, 2025 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@crizy
Copy link

crizy commented Jan 2, 2025

the path : hw/hdl/network/rdma/
the file : rdma_meta_tx_arbiter.sv

the rtl code at line 163 of rdma_meta_tx_arbiter.sv file,

 assign user_seq_in.data = {vfid, request_snk[vfid].req_1.len};

the request_snk[vfid] signal does not exist in rdma_meta_tx_arbiter.sv file, what is in the file is just req_snk[vfid],

so line 163 should be :

 assign user_seq_in.data = {vfid, req_snk[vfid].req_1.len};
@crizy
Copy link
Author

crizy commented Jan 14, 2025

the path : hw\services\network\hls\hash_table
the file : generate_random_table.cpp

the hls code at line 61 of generate_random_table.cpp file,
uint32_t maxKeyValue = pow(keyLength, 2) - 1;

should be :
uint32_t maxKeyValue = pow(2, keyLength) - 1;

@bo3z
Copy link
Collaborator

bo3z commented Jan 14, 2025

Hi @crizy,

Thank you for noticing both of these. Can you please explain a bit what work-loads (protocols, numbers of instances, connections etc.) that you are using. These are obvious syntax errors that we will fix, but for some reason we don't encounter them in our applications. So we would like to understand if there are some other subtle issues for work-loads we may not be using.

Thanks!

@bo3z bo3z added the bug Something isn't working label Jan 14, 2025
@crizy
Copy link
Author

crizy commented Jan 22, 2025

Hi @bo3z ,

 the first rtl syntax errors (rdma_meta_tx_arbiter.sv) was reported when I synthesized the rdma_perf example using U250 FPGA device
 the second (generate_random_table.cpp)was discovered when I was reviewing the HLS code

@bo3z
Copy link
Collaborator

bo3z commented Jan 22, 2025

Thanks @crizy for the explanation. Can you share your CMake configuration with us? We don't seem to be facing these issues on the U55C, so we would like to understand what's different other than the device (number of vFPGAs etc.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants