Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSN resolution no longer working with SOCKS5 #97

Closed
xwitty opened this issue Dec 19, 2023 · 7 comments
Closed

DSN resolution no longer working with SOCKS5 #97

xwitty opened this issue Dec 19, 2023 · 7 comments
Labels
area: DNS DNS related stale Stale issues

Comments

@xwitty
Copy link

xwitty commented Dec 19, 2023

a host - not allowed with my local proxy - is accessible with a SOCKS5-proxy in v7.5.1, but not v8.6

as far as I can say, the DSN-resolution is already blocked, before switching out to the proxy.

@erosman
Copy link
Collaborator

erosman commented Dec 19, 2023

Have you tried Proxy DNS?

BTW, Proxy DNS (was global in v8.6) is moved to per-server in v8.7.

@erosman erosman added the area: DNS DNS related label Dec 19, 2023
@evetsso
Copy link

evetsso commented Dec 21, 2023

I think I ran into the same problem - it seems that a recent update to the extension broke DNS resolution through SOCKS5 for an existing proxy. The proxy I have defined appears to have Proxy DNS enabled when I look at its configuration (presumably this setting was migrated from the previously-global setting).

I am able to work around the problem by disabling Proxy DNS, saving the proxy configuration, re-enabling Proxy DNS, and saving the config again.

@erosman
Copy link
Collaborator

erosman commented Dec 21, 2023

The proxy I have defined appears to have Proxy DNS enabled

Actually, the enabled state is a preset.

I am able to work around the problem by disabling Proxy DNS, saving the proxy configuration, re-enabling Proxy DNS, and saving the config again.

The data is migrated from global to individual proxies per request in #75.

However, the Firefox proxying request process in FoxyProxy is refreshed on browser restart, extension re-enable, background script reload (MV3), and edits in the Options page.
It SHOULD also happen when an extension is upgraded BUT I have seen instances that due to caching by the browser, the extension might not be fully restarted during an upgrade.

I am guessing that for users who keep their browser on all the time, most of those cases wont happen until an edit is made in the Options page (any edit will do).

@erosman
Copy link
Collaborator

erosman commented Jan 5, 2024

Are you still experiencing the issue?

@GlenDC
Copy link

GlenDC commented Jan 17, 2024

I can confirm the bug is still there.
#97 (comment) this resolves it.
But not very UX if it has to happen fequently. Either way that makes it work.

@erosman
Copy link
Collaborator

erosman commented Jan 17, 2024

Can you provide an STR (steps to reproduce) so that I can see what is happening?
When I try, I don't experience the issue.

@erosman erosman added the stale Stale issues label Feb 3, 2024
@erosman erosman closed this as completed Feb 3, 2024
@Francewhoa
Copy link

Related challenge with steps to reproduce and screenshots at #166

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: DNS DNS related stale Stale issues
Projects
None yet
Development

No branches or pull requests

5 participants