From 463e02e17a2b54230609b874571076de02612cfe Mon Sep 17 00:00:00 2001 From: Vladimir Berdnikov Date: Wed, 7 Aug 2024 11:15:05 +0300 Subject: [PATCH] ULMS-3230 Use external_id instead of scope in ulms methods --- package-lock.json | 4 ++-- package.json | 2 +- src/ulms.js | 36 +++++++++++++++--------------------- 3 files changed, 18 insertions(+), 24 deletions(-) diff --git a/package-lock.json b/package-lock.json index 6628667..180afa8 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "@ulms/api-clients", - "version": "7.20.0", + "version": "7.21.0", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "@ulms/api-clients", - "version": "7.20.0", + "version": "7.21.0", "license": "MIT", "dependencies": { "axios": "1.6.2", diff --git a/package.json b/package.json index 6718e01..8a15d9c 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@ulms/api-clients", - "version": "7.20.0", + "version": "7.21.0", "description": "JavaScript API clients for ULMS platform", "keywords": [], "homepage": "https://github.com/foxford/ulms-api-clients-js#readme", diff --git a/src/ulms.js b/src/ulms.js index 4018335..310dd78 100644 --- a/src/ulms.js +++ b/src/ulms.js @@ -113,7 +113,7 @@ class ULMS extends BasicClient { } /** - * Scope kind enum + * Classroom kind enum * @returns {{CHAT: string, MINIGROUP: string, P2P: string, WEBINAR: string}} */ static get kind() { @@ -137,10 +137,10 @@ class ULMS extends BasicClient { } /** - * Scope status enum + * Classroom status enum * @returns {{REAL_TIME: string, CLOSED: string, FINISHED: string, ADJUSTED: string, TRANSCODED: string}} */ - static get scopeStatus() { + static get classroomStatus() { return { REAL_TIME: 'real-time', CLOSED: 'closed', @@ -196,15 +196,14 @@ class ULMS extends BasicClient { } /** - * Commit edition by scope - * @param {string} audience - * @param {string} scope + * Commit edition by classroomId + * @param {string} classroomId * @param {string} editionId * @returns {Promise} */ - commitEdition(audience, scope, editionId) { + commitEdition(classroomId, editionId) { return this.post( - `${this.baseUrl}/audiences/${audience}/classes/${scope}/editions/${editionId}`, + `${this.baseUrl}/classrooms/${classroomId}/editions/${editionId}`, ) } @@ -505,16 +504,15 @@ class ULMS extends BasicClient { } /** - * Read ulms scope + * Read ulms classroom * @param {string} kind - * @param {string} audience - * @param {string} scope + * @param {string} classroomId * @param {object} options * @returns {Promise} */ - readScope(kind, audience, scope, options) { + readClassroom(kind, classroomId, options) { return this.get( - this.url(`/audiences/${audience}/${kind}/${scope}`, options), + this.url(`/${kind}/${classroomId}`, options), requestOptionsWithRetryAndTimeout, ) } @@ -685,18 +683,14 @@ class ULMS extends BasicClient { } /** - * Update ulms scope + * Update ulms classroom * @param {string} kind - * @param {string} audience - * @param {string} scope + * @param {string} classroomId * @param {object} data * @returns {Promise} */ - updateScope(kind, audience, scope, data) { - return this.put( - `${this.baseUrl}/audiences/${audience}/${kind}/${scope}`, - data, - ) + updateClassroom(kind, classroomId, data) { + return this.put(`${this.baseUrl}/${kind}/${classroomId}`, data) } /**