Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Browserify compatibility / getting Inky running in the browser #88

Closed
michaelmcandrew opened this issue Sep 7, 2017 · 2 comments · May be fixed by #89
Closed

Browserify compatibility / getting Inky running in the browser #88

michaelmcandrew opened this issue Sep 7, 2017 · 2 comments · May be fixed by #89

Comments

@michaelmcandrew
Copy link

michaelmcandrew commented Sep 7, 2017 •
edited
Loading

Hello folks,

I am working on an open source email composition client for CiviMail based on Inky but I am having difficulties getting inky to work in the browser using Browserify.

I am assuming that it is possible to run Inky purely in the browser as http://foundation.zurb.com/emails/inliner-v2.html is able to work its magic when I am offline.

To try and isolate the problem, I took the programmatic example from https://github.com/zurb/inky#programmatic-use and created this gist on requirebin: http://requirebin.com/?gist=ec5bc173559a850ef83f419a880fe7f1. Thiis is pretty much the same as I have been taking locally.

You'll notice that the console is reporting an error along the lines of:

7be4d22d-082a-4031-9201-119b0efd57ad:71345 Uncaught TypeError: Cannot read property 'prototype' of undefined
    at patch (blob:http://requirebin.com/7be4d22d-082a-4031-9201-119b0efd57ad:71345:53)
    at Object.<anonymous> (blob:http://requirebin.com/7be4d22d-082a-4031-9201-119b0efd57ad:71206:18)
    at Object.require.237../fs.js (blob:http://requirebin.com/7be4d22d-082a-4031-9201-119b0efd57ad:71443:4)
    at s (blob:http://requirebin.com/7be4d22d-082a-4031-9201-119b0efd57ad:27006:262)
    at blob:http://requirebin.com/7be4d22d-082a-4031-9201-119b0efd57ad:27006:313
    at Object.<anonymous> (blob:http://requirebin.com/7be4d22d-082a-4031-9201-119b0efd57ad:71907:10)
    at Object.require.240.buffer (blob:http://requirebin.com/7be4d22d-082a-4031-9201-119b0efd57ad:72175:4)
    at s (blob:http://requirebin.com/7be4d22d-082a-4031-9201-119b0efd57ad:27006:262)
    at blob:http://requirebin.com/7be4d22d-082a-4031-9201-119b0efd57ad:27006:313
    at Object.require.143.../filterSince (blob:http://requirebin.com/7be4d22d-082a-4031-9201-119b0efd57ad:61082:18)

Which is the same error I have been getting in my local set up.

If would be really ace if you were able to give me some pointers in the right direction / share any insight / build scripts for how you got your own online inliner working.

PS. There is not a lot in the CiviMail Inky Compose repo yet but I can upload and share more details with you if that would be useful.

Thanks a lot!
Michael
@michaelmcandrew
Copy link
Author

Oh, it appears that your inliner is not actually processing any Inky tags. It is just inlining CSS. Hence I am less confident that I'll be able to get it working...

@michaelmcandrew
Copy link
Author

Ooh, I see that you have made a browser only version: http://zurb.com/playground/slinky 😃

And that you made it using Browserify.

Browserifying the following worked for me (without having to pass any options to browserify).

var Inky = require('inky/lib/inky.js')
inky = new Inky()
convertedHtml = inky.releaseTheKraken('<container> <row> <columns> <p>Hello World!</p> </columns> </row> </container>')
console.log(convertedHtml)

@michaelmcandrew michaelmcandrew mentioned this issue Sep 12, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

adding 'in the browser / browserify docs' michaelmcandrew/inky
1 participant
@michaelmcandrew