Upload CI builds as artifacts to Github actions

[wormyrocks]

I see that there's a CI task to make macOS builds. Since there are no official macOS builds anywhere, it would be nice if the output of that task were uploaded as an artifact to the github action: https://github.com/actions/upload-artifact

In particular: I had no problem building mayo on my M1 Mac, but I wanted to send a copy to a friend with an Intel Mac, and ran into issues cross-compiling. Would be much easier to just grab from CI.

[HuguesDelorme]

Hello @wormyrocks
Thanks for your message and sorry for the late answer
It's been a while since I would like to provide arm64 and x64 dmg files for latest version of Mayo(currently 0.9.0)
This tool would be really useful for dmg packaging: https://doc.qt.io/qt-6/macos-deployment.html
I don't have Apple hardware and have a virtual x64 macOS Monterey running in VirtualBox.
Mayo builds fine on that virtual macOS machine but opening document crashes for some unknown reason. I think it's related to bad OpenGL or graphics hardware emulation.
What would be great is having some people like you and @andrsd having Apple hardware to run and check the dmg files created.
Let me know if you agree to help testing this, if other people reading this message are interested then please drop a message in this thread.
I can provide a specific ci-macos.yml file to produce dmg file artifacts so someone can test, just at least one person willing to test

[andrsd]

Just the output of the CI step is not enough. As @HuguesDelorme said, there needs to be one more step which is the deployment one. I do this for x86 version in one of my projects and it seems to work fine, see the relevant step

https://github.com/andrsd/mesh-inspector/blob/d8826143725f5541132550d765fc4b8d267fdc4c/.github/workflows/release.yml#L78-L83

Now that github has the arm64 runner images, this should be also possible for arm64, but I did not try yet.

However, keep in mind that the produced app bundles won't be signed, so users will see the that the app might be malware and will need to jump through several hoops to get the app going. This is fine for experiences mac users, but it will be a FAQ.

If you wanted to sign the app, you need to participate in Apple Dev program (which is ~ $100 year), this will give you the signing certificates and you will need to bundle entitlements. With all that, the app will run smoothly. I do this locally on my machine when deploying my project for arm64. IDK if this can be automated via github action - I did not bother to try.

[HuguesDelorme]

Hello @wormyrocks and @andrsd
I've added some steps to macOS CI to build a dmg file for Mayo, can you download this artifact and let me know if it works?
https://github.com/fougue/mayo/actions/runs/12885554814/artifacts/2460863815

Or grab it from "Upload dmg file" step:
https://github.com/fougue/mayo/actions/runs/12885554814/job/35924263781

Many thanks!

[andrsd]

I downloaded the artifact, installed from the dmg, ran it and got:

If I run from terminal, the binary is killed immediately, and in the report to Apple, I see:

System Integrity Protection: enabled

Crashed Thread:        0

Exception Type:        EXC_BAD_ACCESS (SIGKILL (Code Signature Invalid))
Exception Codes:       UNKNOWN_0x32 at 0x0000000102ff8000
Exception Codes:       0x0000000000000032, 0x0000000102ff8000

Termination Reason:    Namespace CODESIGNING, Code 2 Invalid Page

[HuguesDelorme]

@andrsd Thanks for this fast feedback!
It seems the codesigning is blocking here.
Can you try to run the xattr -cr command?
Found some help at https://discussions.apple.com/thread/255329839?sortBy=rank
Maybe something like xattr -cr /Applications/mayo.app

[andrsd]

That didn't change anything.