Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Susi does not remember what the user told it #181

Open
Manveer695 opened this issue Jun 24, 2017 · 9 comments
Open

Susi does not remember what the user told it #181

Manveer695 opened this issue Jun 24, 2017 · 9 comments

Comments

@Manveer695
Copy link
Contributor

Actual Behaviour
Susi AI does not have a skill to remember what the user told it to.

Screenshots of the skill in google assistant
screenshot_20170624-090713

Would you like to work on the issue?
@dynamitechetan @jyoth1raditya @madhavrathi @DravitLochan please guide if we could use accounts or memory.json to achieve this skill. Then, lets advance on this skill. Thank you.

@DravitLochan
Copy link
Member

Good idea! I too proposed about reminders. @Orbiter Should we go for a servlet for reminders similar to memory servlet?

@hpdang hpdang modified the milestone: Milestone 8 (GSoC 2017) Jun 26, 2017
@Manveer695
Copy link
Contributor Author

@DravitLochan As its a milestone now, let's start discussing how this can be achieved. any ideas?

@Orbiter
Copy link
Contributor

Orbiter commented Jun 29, 2017

Thats easy. No server-side and no client-side implementation is needed. If you read the skill tutorial, you will find out!

@Manveer695
Copy link
Contributor Author

@Orbiter Ok. Thanks! I will check to it.

@Manveer695
Copy link
Contributor Author

Manveer695 commented Jun 30, 2017

@Orbiter
birthdayrememberissue

I need to tackle this type of situation by making a variable named "ali birthday" to store the string "on 20th of feb". If i make a skill using this syntax:
rememberskillbirthdayissue

But what is happening right now is the variable made is of the name "ali" and "birthday" is getting ignored. Is it possible to fix this? Thank you.

@Orbiter
Copy link
Contributor

Orbiter commented Jul 1, 2017

You can see the result of the variable assignments in the data object from the json answer. Is the variable set as you expected?

@Manveer695
Copy link
Contributor Author

@Orbiter No sir, it's not set as expected.
As we can see for string "remember that ali birthday is on 20". the variable saved is of the name "_ali" instead of $1$ being "ali birthday" :
orbitertellissue1

Hence the answer has a "birthday" string as an extra string:
orbitertellissue2

Thanks!

@Orbiter
Copy link
Contributor

Orbiter commented Jul 3, 2017

Hm, very special problem but I believe that should be considered as a bug in the variable assignment. Would you like to have a look where the term gets cut at the space?

@Manveer695
Copy link
Contributor Author

@Orbiter I didn't get you sir. Like i want "ali birthday" to be stored as a variable may be like ali_birthday or any other way. How can that be achieved in a skill? Please guide me. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants