-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat:- Account Section Implementation. #561
base: master
Are you sure you want to change the base?
Conversation
@chashmeetsingh, @jogendra, Please Review the PR |
Updated SS @jogendra, please review and merge this PR. Will solve Other issues related to this PR in other PRs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the UI:
- There should be option to change avatar from clicking the image.
- AspectFit image in avatar imageView
- Align delete button left and keep it just below last textField.
- Add shadow of radius 10 to the avatar imageview and keep border white color
@jogendra, I will do the changes, just to be clear I am thinking of implementing the upload Avatar or image in a different storyboard where user can pick either gravatar, avatar or Image from the gallery by clicking the image view just like we have in our Susi web app. And that's the reason why I made a click button in the account settings storyboard that redirects to the upload image storyboard because making all the things in a single storyboard is somewhat messy. |
I think if you are not adding any additional functionality other than just uploading image then, it will be good to do in same controller |
Yes, I am thinking of implementing the user dashboard in the same storyboard. |
Changes are done @jogendra, I changed the shadow of radius to 2 because if we change it to 10 then it is overlapping with the user Image Here is the updated SS |
Add outer shadow, not inner! |
Done @jogendra Here is the output |
@jogendra, please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update M13Checkbox Pod, it is giving me the errors.
Done @jogendra |
@baquer Have you followed https://stackoverflow.com/questions/26024100/dyld-library-not-loaded-rpath-libswiftcore-dylib to fix the Lint error? |
@jogendra Yes I tried almost every answer, but none of them are working, I think the problem is either with the WWDRCA certificate or with the Circle CI integration. I will try to solve this within this week |
@jogendra On Circle Ci Website I found out this warning "Your project references CircleCI 1.0 or it has no configuration. CircleCI 1.0 and projects without configuration files are no longer supported. You must update your project to use CircleCI 2.0 configuration to continue." |
@baquer We are using version 2. May be change some cofig params or xcode version to get it done. |
Fixes #559, #544, #557
Screenshots for the change: