Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to mark/star messages #53

Closed
chashmeetsingh opened this issue May 12, 2017 · 9 comments
Closed

Ability to mark/star messages #53

chashmeetsingh opened this issue May 12, 2017 · 9 comments

Comments

@chashmeetsingh
Copy link
Member

No description provided.

@chiragw15
Copy link
Member

Discuss this once with Mario if marking the message is actually required? We do have it on android but I am not sure about that. There are chances that it may be removed as it is not much of a use.

@chashmeetsingh
Copy link
Member Author

Will do when I come to this

@mariobehling
Copy link
Member

I am not sure, if this is a priority now, cause this kind of "star" should be implemented in the server as well. So, messages show up as starred on all clients.

@chiragw15 I think this is not the case at the moment with the Android app.

As a rule of thumb - if Google Assistant or Siri has it, then we should have it. If not, then it is lower priority.

@chiragw15
Copy link
Member

@mariobehling In android app we have this feature to star the message but it is done locally only (storing it in android database) and not related to server. So, it won't be displayed on all clients. Google assistant doesn't have this feature too(don't know about siri). This is the reason I asked @chashmeetsingh to confirm it once from you. So, I think this can be delayed for now in IOS and other clients. And for android, what do you suggest? Since it is already implemented, should we remove it or keep it?

@chashmeetsingh
Copy link
Member Author

Is there any use case for the same? Why are we actually starting the messages? @chiragw15

@chiragw15
Copy link
Member

chiragw15 commented Jun 16, 2017

Not much but maybe a case when susi replies with something and user finds it important and may need it in future. So, he may star it and whenever in future he wants it, he may look up for it in starred messages. It has limited use thats why I am asking to delay it for now.

@chashmeetsingh
Copy link
Member Author

chashmeetsingh commented Jun 16, 2017

I suppose if something's impt. user would prefer to create an event, save in calendar or add in the notes / reminder. I guess that's why Siri or Assistant do not have this feature. What do you think?

@chiragw15
Copy link
Member

Yup we have an issue for reminder skill. fossasia/susi_skill_data#108. We can also create a skill to add something to notes.

@mariobehling
Copy link
Member

Ok, I am closing this for now as it does not seem a priority. Thanks for your input!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants