73 Emphasize current active sorted column #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgorzanski
requested changes
Sep 13, 2023
| @@ -1,5 +1,6 @@ | |||
| @import 'variables/breakpoints'; | |||
|
|
|||
| :root { | |||
There was a problem hiding this comment.
Isn't optimizely oui using sass variables for colors? Maybe we should do the same? See node_modules\optimizely-oui\src\oui\_oui-variables.scss for reference
There was a problem hiding this comment.
Also, maybe these colors are declared already? Please search in @optimizely\design-tokens\dist\scss\_colors.scss
There was a problem hiding this comment.
We should reuse as much as possible
| @@ -195,10 +199,11 @@ const ContentTypesView = () => { | |||
| .filter((column) => column.visible) | |||
| .map((column) => ( | |||
| <Table.TH | |||
| className={column.id === sortBy ? activeColumnHeaderClassName : columnHeaderClassName} | |||
There was a problem hiding this comment.
When active, both classes should be added - according to BEM methodology
There was a problem hiding this comment.
I suggest using classNames package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added highlighting currently selected/sorted column header.
I'm aware about duplication. We need better components structure. I'll add issue for that.