Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesign content usage table #69

Merged
merged 11 commits into from
Aug 28, 2023
Merged

Redesign content usage table #69

merged 11 commits into from
Aug 28, 2023

Conversation

Fifok
Copy link
Contributor

@Fifok Fifok commented Aug 9, 2023

According to #61

I redesign content usages table.

I also split ContentTypeUsageView.tsx into content usage table components.

@Fifok Fifok requested a review from mgorzanski August 9, 2023 11:43
This was linked to issues Aug 10, 2023
Open edit and page links in new tab #61
Open
Make Languange colum narrower and URL column wider #64
Open
@mgorzanski
Copy link
Contributor

@darekhalecki suggested to add an edit on hover:
image

@mgorzanski
Copy link
Contributor

I'm not sure if the row with many items should be higher than rest of the rows, I think it would be better to make it the same size as others
image

@Fifok
Copy link
Contributor Author

Fifok commented Aug 16, 2023

@darekhalecki suggested to add an edit on hover: image

I misunderstood that comment! Now I get it and will add it.

@Fifok Fifok requested a review from mgorzanski August 18, 2023 08:17
@Fifok Fifok requested a review from mgorzanski August 18, 2023 09:27
@Fifok Fifok merged commit bb8431b into dev Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgorzanski mgorzanski mgorzanski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make Languange colum narrower and URL column wider Open edit and page links in new tab
2 participants
@Fifok @mgorzanski