Add "All" or "All/None" option to dropdown filters. #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure if this is a good idea to change "All" to "None" when selecting all. For me it looks strange to have a "None" selected and all items visible. |
mgorzanski
requested changes
Jun 20, 2023
src/EpiContentUsage/Frontend/Components/Filters/ColumnsFilter.tsx
Outdated
Show resolved
Hide resolved
src/EpiContentUsage/Frontend/Components/Filters/ContentTypeBasesFilter.tsx
Outdated
Show resolved
Hide resolved
# Conflicts: # src/Forte.Optimizely.ContentUsage/Frontend/Lib/hooks/useFilteredTableData.ts
mgorzanski
approved these changes
Aug 21, 2023
| @@ -29,6 +29,7 @@ interface FilteredTableDataHookOptions<TableDataType> { | |||
| disableFrontendFiltering?: boolean; | |||
| disableFrontendPagination?: boolean; | |||
| disableFrontendSorting?: boolean; | |||
| defaultVisiableColumn: keyof TableDataType; | |||
There was a problem hiding this comment.
Typo here, should be visible
| @@ -5,7 +5,7 @@ import { useTranslations } from "../../Contexts/TranslationsProvider"; | |||
|
|
|||
| interface ContentTypeBasesFilterProps { | |||
| contentTypeBases: ContentTypeBase[]; | |||
| onChange?: (contentTypeBase: ContentTypeBase) => void; | |||
| onChange?: (contentTypeBase: ContentTypeBase, selectAll?: boolean) => void; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to #49