Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend sorting and integrate API sorting with frontend #35

Open
Fifok opened this issue Mar 1, 2023 · 2 comments
Open

Extend sorting and integrate API sorting with frontend #35

Fifok opened this issue Mar 1, 2023 · 2 comments
Assignees
Labels
BE consideration Something to consider / discuss within team FE question Further information is requested

Comments

@Fifok
Copy link
Contributor

Fifok commented Mar 1, 2023

I saw that for Type column (potentially for all columns) sorting isn't working correctly.
If we sort by Type, displayed content types will contains only one "Block" content (for Foundation project of course).
image
On page 6 (with 15 per page items count) we see much more than one "Block" content.
image

After syncing with @mgorzanski we saw that there is sorting on FE and on BE totally independent from each other.

Solution proposal:
Change FE sorting mechanism because we don't have pagination mechanism in ContentType/GetContentTypes endpoint (just sorting, which is not used).

@Fifok Fifok self-assigned this Mar 7, 2023
@Fifok Fifok changed the title Sort by Type (or all columns) isn't working correctly Integrate querying API with frontend Mar 14, 2023
@Fifok
Copy link
Contributor Author

Fifok commented Mar 14, 2023

I changed the title, because we thought, that it'll be better to change filtring/sorting data to use our BE API.

Main reason: we want to avoid sending to a client huge set of data.

@Fifok Fifok changed the title Integrate querying API with frontend Extend sorting and integrate API sorting with frontend Mar 14, 2023
@Fifok
Copy link
Contributor Author

Fifok commented Jun 16, 2023

After #36 it seems to be fixed on FE side.

@darekhalecki @mgorzanski
I prepared #42 and #46 PRs with adding BE sorting and integration in the meantime, but we can consider to not implementing this solution.

@Fifok Fifok added the question Further information is requested label Jun 16, 2023
@Fifok Fifok added the consideration Something to consider / discuss within team label Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BE consideration Something to consider / discuss within team FE question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant