Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: remove MakeSendMarker in favor of direct methods on the underlying types #530

Open
vn971 opened this issue Oct 6, 2023 · 2 comments
Open

Chore: remove MakeSendMarker in favor of direct methods on the underlying types #530

vn971 opened this issue Oct 6, 2023 · 2 comments

Comments

@vn971
Copy link

vn971 commented Oct 6, 2023 •
edited
Loading

Currently, async-usercalls uses an artificial MakeSendMarker trait to specify type boundaries for ByteBuffer, User<ByteBuffer>, User<[u8]> (see async-usercalls/src/utils.rs).

Instead, we could implement some of the underlying methods in those 3 types directly. This requires "upstreaming", so we'll first have to wait for async-usercalls changes to be accepted in the rust-lang repository.
@vn971 vn971 mentioned this issue Oct 6, 2023
Merged
@raoulstrackx
Copy link
Contributor

Started on a branch for the compiler

@raoulstrackx raoulstrackx mentioned this issue Nov 9, 2023
Open
@raoulstrackx
Copy link
Contributor

Submitted a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vn971 @raoulstrackx