Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests for default.yaml #2

Open
breezykermo opened this issue Jul 25, 2019 · 0 comments
Open

tests for default.yaml #2

breezykermo opened this issue Jul 25, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@breezykermo
Copy link
Member

The default.yaml file (which is the configuration for frame when packaged as a Mac app) needs some basic tests, as some inconsistencies fail silently when running. These include:

  • checking that no two events are named the same. The YAML loaded will just take the event furthest down the file if there are collisions.
  • checking that all files in events exist on the filesystem. The non-existence of a video file will result in a fatal "frame error" at startup.
  • checking that time strings are legitimate and return an actual object when converted to schedule events. We didn't realise that daily events (e.g. every().wednesday.at("17:00")) don't allow the specification of seconds, which led to unexpected behavior. Some badly interpreted strings don't seem to fail or crash frame, they just don't register the event.
@breezykermo breezykermo added the enhancement New feature or request label Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant