Sm/no-capital-enforcement-on-plugins #1093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillieRuemmele
requested changes
Jun 21, 2024
test/unit/projectTest.ts
Outdated
| }); | ||
| describe('plugins', () => { | ||
| const pluginsContent = { SomePlugin: 'value', SomeOtherPlugin: { NestedCap: true } }; | ||
| it('allows uppercase packaging aliases on write', async () => { |
There was a problem hiding this comment.
Update UT names for plugins
WillieRuemmele
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
sfdx-project.json has a 3PP prop called
plugins. Allow capital-case keys there.pin ts to avoid 5.5 until nonara/ts-patch#161 is in for ts-patch
drop a dev-dep that was pulled in for a single UT assertion
What issues does this PR fix or reference?
@W-5571825@