Skip to content

Commit

Permalink
test: ut names
Browse files Browse the repository at this point in the history
  • Loading branch information
@mshanemc
mshanemc committed Jun 21, 2024
1 parent 6ee3c61 commit e88f741
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions test/unit/projectTest.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -45,13 +45,13 @@ describe('SfProject', () => {
});
describe('plugins', () => {
const pluginsContent = { SomePlugin: 'value', SomeOtherPlugin: { NestedCap: true } };
it('allows uppercase packaging aliases on write', async () => {
it('allows uppercase keys in plugins on write', async () => {
const json = await SfProjectJson.create();
json.set('plugins', pluginsContent);
await json.write();
expect($$.getConfigStubContents('SfProjectJson').plugins).to.deep.equal(pluginsContent);
});
it('allows uppercase packaging aliases on read', async () => {
it('allows uppercase keys in plugins on read', async () => {
$$.setConfigStubContents('SfProjectJson', { contents: { plugins: pluginsContent } });
const json = await SfProjectJson.create();
expect(json.get('plugins')).to.deep.equal(pluginsContent);
Expand Down

2 comments on commit e88f741

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logger Benchmarks - ubuntu-latest

Benchmark suite Current: e88f741 Previous: 6ee3c61 Ratio
Child logger creation 467749 ops/sec (±2.35%) 471782 ops/sec (±1.32%) 1.01
Logging a string on root logger 713829 ops/sec (±8.69%) 784242 ops/sec (±8.55%) 1.10
Logging an object on root logger 634704 ops/sec (±8.41%) 619397 ops/sec (±8.68%) 0.98
Logging an object with a message on root logger 8887 ops/sec (±202.35%) 5988 ops/sec (±211.84%) 0.67
Logging an object with a redacted prop on root logger 468133 ops/sec (±13.64%) 449800 ops/sec (±7.35%) 0.96
Logging a nested 3-level object on root logger 402002 ops/sec (±6.40%) 344327 ops/sec (±8.73%) 0.86

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logger Benchmarks - windows-latest

Benchmark suite Current: e88f741 Previous: 6ee3c61 Ratio
Child logger creation 329149 ops/sec (±0.79%) 324718 ops/sec (±0.80%) 0.99
Logging a string on root logger 737202 ops/sec (±5.95%) 747402 ops/sec (±4.67%) 1.01
Logging an object on root logger 593848 ops/sec (±4.45%) 584520 ops/sec (±13.52%) 0.98
Logging an object with a message on root logger 6190 ops/sec (±204.15%) 7529 ops/sec (±201.11%) 1.22
Logging an object with a redacted prop on root logger 476806 ops/sec (±6.94%) 444036 ops/sec (±5.62%) 0.93
Logging a nested 3-level object on root logger 336007 ops/sec (±4.68%) 316245 ops/sec (±5.09%) 0.94

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.