Skip to content

Commit

Permalink
style: non camel-case tests
Browse files Browse the repository at this point in the history
  • Loading branch information
@mshanemc
mshanemc committed May 16, 2024
1 parent 72288ab commit 44fce1d
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions test/unit/logger/filterTest.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ describe('filters', () => {
});

it('filters clientId correctly (separator)', () => {
// eslint-disable-next-line camelcase
const result = getUnwrapped({ Client_Id: 'clientIdValue' });
assert(result);
const bigString = JSON.stringify(result);
Expand Down Expand Up @@ -143,6 +144,7 @@ describe('filters', () => {
expect(result).to.deep.equal(input);
});
it('default connected app (case insensitive)', () => {
// eslint-disable-next-line camelcase
const input = { client_id: 'Platform CLI' };
const result = getUnwrapped(input);
expect(result).to.deep.equal(input);
Expand Down

3 comments on commit 44fce1d

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logger Benchmarks - ubuntu-latest

Benchmark suite Current: 44fce1d Previous: 39b81b8 Ratio
Child logger creation 478671 ops/sec (±2.04%) 458773 ops/sec (±1.27%) 0.96
Logging a string on root logger 844310 ops/sec (±8.86%) 811115 ops/sec (±7.13%) 0.96
Logging an object on root logger 42294 ops/sec (±183.66%) 626839 ops/sec (±7.01%) 14.82
Logging an object with a message on root logger 436249 ops/sec (±8.53%) 8112 ops/sec (±207.82%) 0.018594885031255087
Logging an object with a redacted prop on root logger 491260 ops/sec (±8.39%) 522398 ops/sec (±8.71%) 1.06
Logging a nested 3-level object on root logger 18812 ops/sec (±186.57%) 391256 ops/sec (±6.56%) 20.80

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Logger Benchmarks - ubuntu-latest'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 44fce1d Previous: 39b81b8 Ratio
Logging an object on root logger 42294 ops/sec (±183.66%) 626839 ops/sec (±7.01%) 14.82
Logging a nested 3-level object on root logger 18812 ops/sec (±186.57%) 391256 ops/sec (±6.56%) 20.80

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logger Benchmarks - windows-latest

Benchmark suite Current: 44fce1d Previous: 0ea16f0 Ratio
Child logger creation 324407 ops/sec (±0.80%) 319275 ops/sec (±0.64%) 0.98
Logging a string on root logger 757278 ops/sec (±4.91%) 749631 ops/sec (±5.29%) 0.99
Logging an object on root logger 556922 ops/sec (±6.19%) 650717 ops/sec (±6.40%) 1.17
Logging an object with a message on root logger 8465 ops/sec (±190.76%) 5687 ops/sec (±206.03%) 0.67
Logging an object with a redacted prop on root logger 460212 ops/sec (±11.04%) 406254 ops/sec (±13.46%) 0.88
Logging a nested 3-level object on root logger 332885 ops/sec (±5.14%) 327752 ops/sec (±4.92%) 0.98

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.